style: apply pr comments

apps/web/src/pages/block/[id].tsx

@@ -3,7 +3,7 @@ import type { NextPage } from "next";
 import { useRouter } from "next/router";
 import type { NextRouter } from "next/router";
 
-import { getNetworkBlobConfig } from "@blobscan/network-blob-config";
+import { getNetworkBlobConfigBySlot } from "@blobscan/network-blob-config";
 
 import { Card } from "~/components/Cards/Card";
 import { BlobTransactionCard } from "~/components/Cards/SurfaceCards/BlobTransactionCard";
@@ -72,7 +72,7 @@ const Block: NextPage = function () {
   let detailsFields: DetailsLayoutProps["fields"] | undefined;
 
   if (blockData && env) {
-    const networkBlobConfig = getNetworkBlobConfig(
+    const networkBlobConfig = getNetworkBlobConfigBySlot(
       env.PUBLIC_NETWORK_NAME,
       blockData.slot
     );

apps/web/src/pages/blocks.tsx

@@ -1,7 +1,7 @@
 import { useMemo, useState } from "react";
 import type { NextPage } from "next";
 
-import { getNetworkBlobConfig } from "@blobscan/network-blob-config";
+import { getNetworkBlobConfigBySlot } from "@blobscan/network-blob-config";
 
 import { Copyable } from "~/components/Copyable";
 import { BlobGasUsageDisplay } from "~/components/Displays/BlobGasUsageDisplay";
@@ -265,7 +265,7 @@ const Blocks: NextPage = function () {
           {
             item: (
               <BlobGasUsageDisplay
-                networkBlobConfig={getNetworkBlobConfig(
+                networkBlobConfig={getNetworkBlobConfigBySlot(
                   env.PUBLIC_NETWORK_NAME,
                   slot
                 )}

packages/api/src/routers/indexer/indexData.utils.ts

@@ -10,7 +10,7 @@ import type {
 import { Prisma } from "@blobscan/db";
 import { Category } from "@blobscan/db/prisma/enums";
 import { env } from "@blobscan/env";
-import { getNetworkBlobConfig } from "@blobscan/network-blob-config";
+import { getNetworkBlobConfigBySlot } from "@blobscan/network-blob-config";
 import { getRollupByAddress } from "@blobscan/rollups";
 
 import type { IndexDataFormattedInput } from "./indexData";
@@ -66,10 +66,8 @@ export function calculateBlobGasPrice(
   slot: number,
   excessBlobGas: bigint
 ): bigint {
-  const { minBlobBaseFee, blobBaseFeeUpdateFraction } = getNetworkBlobConfig(
-    env.CHAIN_ID,
-    slot
-  );
+  const { minBlobBaseFee, blobBaseFeeUpdateFraction } =
+    getNetworkBlobConfigBySlot(env.CHAIN_ID, slot);
 
   return BigInt(
     fakeExponential(minBlobBaseFee, excessBlobGas, blobBaseFeeUpdateFraction)
@@ -94,7 +92,10 @@ export function createDBTransactions({
         BigInt(0)
       );
 
-      const ethereumConfig = getNetworkBlobConfig(env.CHAIN_ID, block.slot);
+      const ethereumConfig = getNetworkBlobConfigBySlot(
+        env.CHAIN_ID,
+        block.slot
+      );
       const blobGasPrice = calculateBlobGasPrice(
         block.slot,
         block.excessBlobGas

packages/db/prisma/seed/DataGenerator.ts

@@ -22,7 +22,7 @@ import {
   ROLLUP_ADDRESSES,
 } from "./web3";
 
-const BLOB_GAS_PER_BLOB = FORK_BLOB_CONFIGS["dencun"].gasPerBlob;
+const GAS_PER_BLOB = FORK_BLOB_CONFIGS["dencun"].gasPerBlob;
 
 export type FullBlock = Block & {
   transactions: (Transaction & {
@@ -87,7 +87,7 @@ export class DataGenerator {
     });
     const proof = faker.string.hexadecimal({ length: 96 });
     const versionedHash = `0x01${sha256(commitment).slice(2)}`;
-    const size = Number(BLOB_GAS_PER_BLOB);
+    const size = Number(GAS_PER_BLOB);
 
     return {
       commitment,
@@ -130,7 +130,7 @@ export class DataGenerator {
       min: 1,
       max: 6,
     });
-    const blobGasUsed = BLOB_GAS_PER_BLOB * BigInt(txsCount);
+    const blobGasUsed = GAS_PER_BLOB * BigInt(txsCount);
     const excessBlobGas = calculateExcessBlobGas(
       BigInt(parentBlock.excessBlobGas.toString()),
       BigInt(
@@ -162,7 +162,7 @@ export class DataGenerator {
     uniqueAddresses: string[]
   ): Transaction[] {
     const now = new Date();
-    const maxBlobs = Number(block.blobGasUsed) / Number(BLOB_GAS_PER_BLOB);
+    const maxBlobs = Number(block.blobGasUsed) / Number(GAS_PER_BLOB);
 
     const txCount = faker.number.int({
       min: 1,
@@ -207,9 +207,7 @@ export class DataGenerator {
         .arrayElement(COMMON_MAX_FEE_PER_BLOB_GAS)
         .toString();
       const extraBlobs = faker.number.int({ min: 0, max: remainingBlobs });
-      const blobGasUsed = (
-        BigInt(1 + extraBlobs) * BLOB_GAS_PER_BLOB
-      ).toString();
+      const blobGasUsed = (BigInt(1 + extraBlobs) * GAS_PER_BLOB).toString();
 
       remainingBlobs -= extraBlobs;
 
@@ -236,7 +234,7 @@ export class DataGenerator {
 
   generateTransactionBlobs(tx: Transaction, prevBlobs: Blob[]): Blob[] {
     return Array.from({
-      length: Number(tx.blobGasUsed) / Number(BLOB_GAS_PER_BLOB),
+      length: Number(tx.blobGasUsed) / Number(GAS_PER_BLOB),
     }).map(() => {
       const isUnique = tx.rollup
         ? true

packages/network-blob-config/index.ts

@@ -45,7 +45,10 @@ export const FORK_BLOB_CONFIGS: Record<NetworkFork, NetworkBlobConfig> = {
   },
 };
 
-export function getNetworkFork(network: Network, slot: number): NetworkFork {
+export function getNetworkForkBySlot(
+  network: Network,
+  slot: number
+): NetworkFork {
   switch (network) {
     case "holesky": {
       return slot >= 3710976 ? "pectra" : "dencun";
@@ -72,15 +75,15 @@ function getNetworkNameById(networkId: number): Network {
       return "devnet";
   }
 }
-export function getNetworkBlobConfig(
+export function getNetworkBlobConfigBySlot(
   networkNameOrId: Network | number,
   slot: number
 ): NetworkBlobConfig {
   const network =
     typeof networkNameOrId === "number"
       ? getNetworkNameById(networkNameOrId)
       : networkNameOrId;
-  const upgrade = getNetworkFork(network, slot);
+  const upgrade = getNetworkForkBySlot(network, slot);
 
   return FORK_BLOB_CONFIGS[upgrade];
 }