Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp or temperature? #203

Open
asmeurer opened this issue Feb 7, 2025 · 0 comments
Open

temp or temperature? #203

asmeurer opened this issue Feb 7, 2025 · 0 comments

Comments

@asmeurer
Copy link

asmeurer commented Feb 7, 2025

The APIs here are inconsistent in the use of temp vs. temperature. Some of the example notebooks even show passing temperature to generate, even though the parameter is called temp. Apparently it just ignores unknown keyword arguments due to the way it passes **kwargs around.

I would suggest normalizing to one spelling throughout (IMO temperature is better), and perhaps keeping the old one where it currently exists for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant