Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lidar collector can be started (from code) even when power is not switched on #3

Open
BjAlvestad opened this issue Jun 5, 2019 · 0 comments
Labels
improvement Someting could be improved

Comments

@BjAlvestad
Copy link
Owner

This is not an issue via the GUI since it is only possible to switch on the collector if the power is already on. This is ensured since the "Power" must first be switched on before the collector button becomes visible.
Switching off the power will cause the collector to switch off automatically as well.

However when writing control logic it is possible to start the collector witout the power first being switched on. This will not cause any harm, but the collector will wait for data, which will never arrive, since the Lidar is not actually running.

Possible alternatives for improvements:

Automatically power up lidar when collector is started
Advantage: user friendly.
Disadvantage: too much happening behind the scenes. May power up unintentionally.

Throw exception when trying to start collector when power is off
Advantage: Predictable. No automatic start of equipment.
Disadvantage: May cause unhandled exception for e.g. bindings to collector property from XAML, or other code without try-catch.

Common switch/property for both power and running collector
Advantage: very user fiendly.
Disadvantage: Not possible to stop collector (to reduce CPU usage) without also powering down Lidar. Stopping and starting lidar frequently is not desirable due to several seconds startup time.

@BjAlvestad BjAlvestad added the improvement Someting could be improved label Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Someting could be improved
Projects
None yet
Development

No branches or pull requests

1 participant