Removes some of the old "ToDo" and "TEMP" comments

BjAlvestad · Jun 6, 2019 · 69370a7 · 69370a7
1 parent ed9c7d6
commit 69370a7
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 9 deletions.
diff --git a/SensorVehicle-main/Application/ViewModels/LidarViewModel.cs b/SensorVehicle-main/Application/ViewModels/LidarViewModel.cs
@@ -131,7 +131,6 @@ private async void Lidar_PropertyChanged(object sender, System.ComponentModel.Pr
             if (AutoCalculateLargestDistance)
             {
                 HorizontalPoint point = Lidar.LargestDistance;
-                //TODO: check if running this on UI-thread causes freezing (on weaker hardware). If it does: wrap in Task.Run. If it doesn't, then check AutoCalcDirections, and HorizontalPoints, if they also run ok on UI thread.
             }
 
             if (CalculateHorizontalPoints)

diff --git a/SensorVehicle-main/Application/Views/LidarPage.xaml b/SensorVehicle-main/Application/Views/LidarPage.xaml
@@ -70,7 +70,6 @@
 
                         <TextBlock Text="MinRange:" />
                         <ComboBox SelectedItem="{x:Bind ViewModel.Lidar.Config.MinRange, Mode=TwoWay}" >
-                            <!--TODO: Make combobox editable and robust. Fix issue where 0.7 gets displayed as long number (0.69.....) when combobox is editable -->
                             <!--Official minimum range is 1.0m (Ref. manual). See https://github.com/ros-drivers/velodyne/issues/61 for a discussion on alternative minimum ranges for VLP-16.-->
                             <x:Double>0.1</x:Double>
                             <x:Double>0.3</x:Double>

diff --git a/SensorVehicle-main/Communication/Simulator/SimulatedLidarPacketReceiver.cs b/SensorVehicle-main/Communication/Simulator/SimulatedLidarPacketReceiver.cs
@@ -8,7 +8,7 @@ namespace Communication.Simulator
 {
     public class SimulatedLidarPacketReceiver : ILidarPacketReceiver
     {
-        private const int TimePerCycle = 200;  //TODO: Check exact time spent per cycle for real PacketReceiver, and correct TimePerCycle constant.
+        private const int TimePerCycle = 200;
         private SimulatorAppServiceClient _simulatorCommunication;
         private LidarFormatPacketGenerator _packetGenerator;
 

diff --git a/SensorVehicle-main/Communication/Vehicle/LidarPacketReceiver.cs b/SensorVehicle-main/Communication/Vehicle/LidarPacketReceiver.cs
@@ -67,14 +67,14 @@ public async Task<Queue<byte[]>> GetQueueOfDataPacketsAsync(byte numberOfCycles
 
         public byte[] GetDataPacket()
         {
-            byte[] dataPacket = Udp.Receive(ref _lidarIpEp);  //TODO: Change to async
+            byte[] dataPacket = Udp.Receive(ref _lidarIpEp);
 
             return (dataPacket.Length == DataPayloadSize) ? dataPacket : null;
         }
 
         public async Task<byte[]> GetDataPacketAsync()
         {
-            var receiveResult = await Udp.ReceiveAsync();  //TODO: Change to async
+            var receiveResult = await Udp.ReceiveAsync();
 
             return (receiveResult.Buffer.Length == DataPayloadSize) ? receiveResult.Buffer : null;
         }

diff --git a/SensorVehicle-main/ExampleLogic/ConceptLogics/TurnToLargestDistance.cs b/SensorVehicle-main/ExampleLogic/ConceptLogics/TurnToLargestDistance.cs
@@ -51,7 +51,7 @@ public override void Run(CancellationToken cancellationToken)
 
             float angleToLargestDistance = _lidar.LargestDistance.Angle;
 
-            if (float.IsNaN(angleToLargestDistance))  //TODO: Make LIDAR class throw exception when calling methods (or when accessing Distance) when power is off, or collector not running.
+            if (float.IsNaN(angleToLargestDistance))
             {
                 _wheels.Stop();
                 Debug.WriteLine("STOPPED WHEELS due to no LIDAR distance found!", "ControlLogic");

diff --git a/SensorVehicle-main/VehicleEquipment/DistanceMeasurement/Lidar/LidarDistance.cs b/SensorVehicle-main/VehicleEquipment/DistanceMeasurement/Lidar/LidarDistance.cs
@@ -237,7 +237,6 @@ public List<HorizontalPoint> GetHorizontalPointsInRange(float fromAngle, float t
 
             int startIndex = Distances[verticalAngle].FindIndex(point => point.Angle > fromAngle);
 
-            //TEMP: New logic (and list is first sorted in LidarPacketInterpreter). Check which is fastest. Old or this.
             if (angleSpansZero)
             {
                 if (startIndex != -1)

diff --git a/SensorVehicle-main/VehicleEquipment/DistanceMeasurement/Lidar/LidarDistanceConfiguration.cs b/SensorVehicle-main/VehicleEquipment/DistanceMeasurement/Lidar/LidarDistanceConfiguration.cs
@@ -12,7 +12,7 @@ public class LidarDistanceConfiguration : ThreadSafeNotifyPropertyChanged
         public LidarDistanceConfiguration(VerticalAngle[] verticalAngles)
         {
             DefaultHalfBeamOpening = 15;
-            DefaultCalculationType = CalculationType.Max; //TEMP
+            DefaultCalculationType = CalculationType.Max;
 
             ActiveVerticalAngles = new ExclusiveSynchronizedObservableCollection<VerticalAngle>();
             DefaultVerticalAngle = verticalAngles[0];

diff --git a/SensorVehicle-main/VehicleEquipment/DistanceMeasurement/Lidar/LidarPacketInterpreter.cs b/SensorVehicle-main/VehicleEquipment/DistanceMeasurement/Lidar/LidarPacketInterpreter.cs
@@ -25,7 +25,7 @@ public static ReadOnlyDictionary<VerticalAngle, List<HorizontalPoint>> Interpret
                 }
             }
 
-            SortLidarDistances(interpretedData);  //TODO: Check if list should be sortet before sending out, or iterated for each check in LidarDistance class
+            SortLidarDistances(interpretedData);
 
             return new ReadOnlyDictionary<VerticalAngle, List<HorizontalPoint>>(interpretedData);
         }
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                 }
-                SortLidarDistances(interpretedData);  //TODO: Check if list should be sortet before sending out, or iterated for each check in LidarDistance class
+                SortLidarDistances(interpretedData);
                 return new ReadOnlyDictionary<VerticalAngle, List<HorizontalPoint>>(interpretedData);
             }
@@ Expand Down @@