*Fix mempool issue on Windows

ReleaseNotes.md

@@ -1,5 +1,10 @@
 ## Release Notes
 
+### v1.18.7.3
+- Fix mempool issue on Windows
+- Added API for block explorer
+- Fix payment proof generation.
+
 ### v1.18.6.22
 - Change POW algo (CryptoNight Lite, Variation 1)
 - Change Difficulty algo (LWMA-2)

src/Core/BlockChainState.cpp

@@ -684,6 +684,7 @@ AddTransactionResult BlockChainState::add_transaction(const Hash &tid, const Tra
 		if (input.type() == typeid(KeyInput)) {
 			const KeyInput &in = boost::get<KeyInput>(input);
 			if (read_keyimage(in.key_image)) {
+				m_log(logging::INFO) << "TX! hash=" << common::pod_to_hex(tid) << " count=" << m_memory_state_tx.size() << std::endl;
 				//				std::cout << common::pod_to_hex(tid) << " " << common::pod_to_hex(in.key_image) <<
 				//std::endl;
 				return AddTransactionResult::OUTPUT_ALREADY_SPENT;  // Already spent in main chain
@@ -756,7 +757,7 @@ AddTransactionResult BlockChainState::add_transaction(const Hash &tid, const Tra
 	                            //: m_memory_state_fee_tx.begin()->first;
 	//	if( m_memory_state_total_size-min_size >= MAX_POOL_SIZE)
 	//		std::cout << "Aha" << std::endl;
-	m_log(logging::INFO) << "TX+ hash=" << common::pod_to_hex(tid) << " size=" << my_size << " count=" << m_memory_state_tx.size();
+	m_log(logging::INFO) << "TX+ hash=" << common::pod_to_hex(tid) << " size=" << my_size << " count=" << m_memory_state_tx.size() << std::endl;
 	                     //<< " fee=" << my_fee << " f/b=" << my_fee_per_byte << " current_pool_size=("
 	                     //<< m_memory_state_total_size - min_size << "+" << min_size << ")=" << m_memory_state_total_size
 	                     //<< " count=" << m_memory_state_tx.size() << " min fee/byte=" << min_fee_per_byte << std::endl;
@@ -801,7 +802,7 @@ void BlockChainState::remove_from_pool(Hash tid) {
 	//auto min_fee_per_byte = m_memory_state_fee_tx.empty() || m_memory_state_fee_tx.begin()->second.empty()
 	                            //? 0
 	                            //: m_memory_state_fee_tx.begin()->first;
-	m_log(logging::INFO) << "TX- hash=" << common::pod_to_hex(tid) << " size=" << my_size << " count=" << m_memory_state_tx.size();
+	m_log(logging::INFO) << "TX- hash=" << common::pod_to_hex(tid) << " size=" << my_size << " count=" << m_memory_state_tx.size() << std::endl;
 	                     //<< " current_pool_size=(" << m_memory_state_total_size - min_size << "+" << min_size << ")="
 	                     //<< m_memory_state_total_size << " count=" << m_memory_state_tx.size()
 	                     //<< " min fee/byte=" << min_fee_per_byte << std::endl;

src/bitsum.rc

@@ -5,8 +5,8 @@
 //
 
 1 VERSIONINFO
- FILEVERSION 1,18,6,22
- PRODUCTVERSION 1,18,6,22
+ FILEVERSION 1,18,7,3
+ PRODUCTVERSION 1,18,7,3
  FILEFLAGSMASK 0x3fL
  FILEFLAGS 0x0L
  FILEOS 0x40004L
@@ -19,12 +19,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Bitsum Foundation"
             VALUE "FileDescription", "Bitsum"
-            VALUE "FileVersion", "1.18.6.22"
+            VALUE "FileVersion", "1.18.7.3"
             VALUE "InternalName", "bitsum.rc"
             VALUE "LegalCopyright", "Copyright (C) Bitsum Foundation, 2018"
             VALUE "OriginalFilename", "bitsum.rc"
             VALUE "ProductName", "Bitsum"
-            VALUE "ProductVersion", "1.18.6.22"
+            VALUE "ProductVersion", "1.18.7.3"
         END
     END
     BLOCK "VarFileInfo"

src/platform/DBsqlite3.cpp

@@ -187,6 +187,12 @@ static std::pair<const unsigned char *, size_t> get(const sqlite::Stmt &stmt, co
 	auto da = reinterpret_cast<const unsigned char *>(sqlite3_column_blob(stmt.handle, 0));
 	si      = sqlite3_column_bytes(stmt.handle, 1);
 	da      = reinterpret_cast<const unsigned char *>(sqlite3_column_blob(stmt.handle, 1));
+
+	if (da == nullptr)
+	{
+		da = new unsigned char[0];
+	}
+
 	return std::make_pair(da, si);
 }
 

src/version.hpp

@@ -4,8 +4,8 @@
 #pragma once
 
 // defines are for Windows resource compiler
-#define bytecoin_VERSION_WINDOWS_COMMA 1, 18, 6, 22
-#define bytecoin_VERSION_STRING "1.18.6.22"
+#define bytecoin_VERSION_WINDOWS_COMMA 1, 18, 7, 3
+#define bytecoin_VERSION_STRING "1.18.7.3"
 
 #ifndef RC_INVOKED  // Windows resource compiler