Skip to content

refactor(sdk-core): making supportsMultiSig as coin feature #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lokesh-bitgo
Copy link
Contributor

Ticket: WP-4028

Refactored this PR by making supportsMultiSig() as coin feature.

@lokesh-bitgo lokesh-bitgo marked this pull request as ready for review May 6, 2025 08:16
@lokesh-bitgo lokesh-bitgo requested review from a team as code owners May 6, 2025 08:16
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on slack. Still need to keep the method but mark as deprecated.

@lokesh-bitgo lokesh-bitgo force-pushed the WP-4028-create-coin-feature-multisig-in-statics branch from e9d7ec2 to a7a6bdf Compare May 8, 2025 11:16
@lokesh-bitgo lokesh-bitgo force-pushed the WP-4028-create-coin-feature-multisig-in-statics branch from a7a6bdf to 46e4ba3 Compare May 8, 2025 11:23
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lokesh-bitgo lokesh-bitgo merged commit a14bead into master May 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants