feat(root): add key validation function #6064
Conversation
mohammadalfaiyazbitgo
force-pushed
the
WP-4242/audit-key-method
branch
from
4d2cdd7 to
026a33b
Compare
mohammadalfaiyazbitgo
changed the title
| if (secret.length !== 128 && secret.length !== 192 && secret.length <= 192) { | ||
| return { isValid: false, message: 'Incorrect TSS keychain' }; | ||
| } | ||
| } else if (multiSigType === 'onchain' && publicKey) { |
There was a problem hiding this comment.
if publicKey isn't provided we should be returning isValid:false for multisig no?
There was a problem hiding this comment.
actually we should throw an error, saying public key needs to be provided to validate multisig key
There was a problem hiding this comment.
if publicKey isn't provided we should be returning isValid:false for multisig no?
Actually the problem is that the encrypted prv on the key card doesn't have a public key for user/backup on multiSig Wallets. It just has BitGo's public key.
There was a problem hiding this comment.
ok if that's the case, we need to at least validate the private key somehow, i.e. length, format, etc... as it stands the code wont validate anything if there isnt a public key provided for multisig
There was a problem hiding this comment.
i understand though length could be tricky since private keys are probably stored encoded based on how the coin likes to encode its prv's . If we can instantiate a coin instance and that coin instance has some validate key function that would be nice
Add utility function to validate that an encrypted key can be succesfully decrypted and is a valid key.
Ticket: WP-4242
TICKET: WP-4242