From e7e8785a9f8cf2f4b226ce8bce0f3799814e68f3 Mon Sep 17 00:00:00 2001 From: currantw Date: Mon, 6 Jan 2025 09:45:19 -0800 Subject: [PATCH] Clarify test name, use multi-line string. Signed-off-by: currantw --- .../flint/spark/ppl/FlintSparkPPLParseITSuite.scala | 10 +++++++--- .../ppl/PPLLogicalPlanParseTranslatorTestSuite.scala | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/integ-test/src/integration/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLParseITSuite.scala b/integ-test/src/integration/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLParseITSuite.scala index 54b14f466..faf5b9f81 100644 --- a/integ-test/src/integration/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLParseITSuite.scala +++ b/integ-test/src/integration/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLParseITSuite.scala @@ -211,11 +211,16 @@ class FlintSparkPPLParseITSuite comparePlans(expectedPlan, logicalPlan, checkAnalysis = false) } - test("test parse email & host expressions including cast and sort commands") { + test("test parse street number & street expressions including cast and sort commands") { // TODO #963: Implement 'num', 'str', and 'ip' sort syntax val frame = sql(s""" - | source=$testTable | parse address '(?\\d+) (?.+)' | eval streetNumberInt = cast(streetNumber as integer) | where streetNumberInt > 500 | sort streetNumberInt | fields streetNumber, street + | source = $testTable | + | parse address '(?\\d+) (?.+)' | + | eval streetNumberInt = cast(streetNumber as integer) | + | where streetNumberInt > 500 | + | sort streetNumberInt | + | fields streetNumber, street | """.stripMargin) // Retrieve the results val results: Array[Row] = frame.collect() @@ -264,5 +269,4 @@ class FlintSparkPPLParseITSuite assert(compareByString(expectedPlan) === compareByString(logicalPlan)) } - } diff --git a/ppl-spark-integration/src/test/scala/org/opensearch/flint/spark/ppl/PPLLogicalPlanParseTranslatorTestSuite.scala b/ppl-spark-integration/src/test/scala/org/opensearch/flint/spark/ppl/PPLLogicalPlanParseTranslatorTestSuite.scala index 5a9ba9a01..4cde6c994 100644 --- a/ppl-spark-integration/src/test/scala/org/opensearch/flint/spark/ppl/PPLLogicalPlanParseTranslatorTestSuite.scala +++ b/ppl-spark-integration/src/test/scala/org/opensearch/flint/spark/ppl/PPLLogicalPlanParseTranslatorTestSuite.scala @@ -121,7 +121,7 @@ class PPLLogicalPlanParseTranslatorTestSuite assert(compareByString(expectedPlan) === compareByString(logPlan)) } - test("test parse email & host expressions including cast and sort commands") { + test("test parse street number & street expressions including cast and sort commands") { val context = new CatalystPlanContext // TODO #963: Implement 'num', 'str', and 'ip' sort syntax