Development branch (#321)

* Fixing Pre-2002 data bug in fg_batter_leaders function  (#320)

* Update fg_pitcher_leaders.R

Removed variable renaming line that was breaking the function

* Update fg_batter_leaders.R

Removed renaming line that was breaking the function when used for years < 2002 due to fangraphs' addition of pitch f/x data

* update tests

---------

Co-authored-by: williamohandley <149746808+williamohandley@users.noreply.github.com>

R/fg_batter_leaders.R

@@ -453,7 +453,6 @@ fg_batter_leaders <- function(
           "wRC_plus" = "wRC+",
           "WPA_minus" = "-WPA",
           "WPA_plus" = "+WPA", 
-          "FBall_pct" = "FB_pct1",
           "AgeRng" = "AgeR",
           "team_name" = "TeamName",
           "team_name_abb" = "TeamNameAbb") %>%

R/fg_pitcher_leaders.R

@@ -526,7 +526,6 @@ fg_pitcher_leaders <- function(
           "Relief_IP" = "Relief-IP",
           "WPA_minus" = "-WPA",
           "WPA_plus" = "+WPA", 
-          "FBall_pct" = "FB_pct1",
           "AgeRng" = "AgeR",
           "team_name" = "TeamName",
           "team_name_abb" = "TeamNameAbb") %>%
@@ -563,4 +562,4 @@ fg_pitcher_leaders <- function(
 #' @return A data frame of pitcher data.
 #' @keywords legacy
 #' @export
-fg_pitch_leaders <- fg_pitcher_leaders
+fg_pitch_leaders <- fg_pitcher_leaders

tests/testthat/test-fg_batter_leaders.R

@@ -84,7 +84,7 @@ cols <- c(
   "PH",
   "WPA_LI",
   "Clutch",
-  "FBall_pct",
+  "FB_pct1",
   "FBv",
   "SL_pct",
   "SLv",

tests/testthat/test-fg_pitcher_leaders.R

@@ -87,7 +87,7 @@ cols <- c(
   "Games",
   "WPA_LI",
   "Clutch",
-  "FBall_pct",
+  "FB_pct1",
   "FBv",
   "SL_pct",
   "SLv",

tests/testthat/test-statcast_leaderboards.R

@@ -8,6 +8,7 @@ cols <- c(
   "anglesweetspotpercent",
   "max_hit_speed",
   "avg_hit_speed",
+  "ev50",
   "fbld",
   "gb",
   "max_distance",