Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Von Neumann Class - a mid-pop solgov ship #2656

Open
wants to merge 207 commits into
base: master
Choose a base branch
from

Conversation

Pockets-byte
Copy link
Contributor

@Pockets-byte Pockets-byte commented May 20, 2024

About The Pull Request

I've been playing NSV on and off recently, and many of the ships we play on have some glaring issues- the first of which being that they're all... Just. Too. Big.
the first goal of this ship is to reach near full functionality in less space use, to allow crew function more effectively during combat and out of it- in this it currently is a little over half the size of the atlas while still mounting most of what I'd consider an effective ship to need. secondly, the other solgov ship currently in rotation suffers from a serious lack of redundancy, and is frankly too big for it's crew complement, the von Neumann was designed almost from the ground up with redundancy and damage control in mind, although this has been toned down. in addition, solgov ships suffer from muni being overly simplified, which this ship also attempts to address via the inclusion of a full VLS system and a strong emphasis on muni-operated laser PDCs, as well as generally requiring at least one person per weapon
finally this ship does nothing to singularity engines =(

the ship itself is powered by an overclocked ANGCR, and has a disconnected TEG for people who want even more power. it also mounts a shield, and has provisioning mostly inspired or copied from the wisp. for armament, there are six laser PDCs, a small full VLS system with 8 silos. a heavy LAMS system, and two burst phasers. it has no heavy weapons, and will be the most fragile ship in the game comparatively, but the powerful reactor and high maneuverability make up for that
most departments exist in some form on this ship, although a few things have been cut in the name of compactness, there is no church or chaplain, no lawyer, no viro, brig physican, deputy, or ATC. in keeping with the star-treky theme of solgov, the ship does mount replicators in a couple places, although there is both botany and a kitchen-bar.
maint was initially overlooked, but has some presence. and the there are two hangars and a full turing drive as with respects to the ship's higher crew requirements.
the ship's sprite is also fully animated, and has semi-realistic navigation lights

description very out of date

Why It's Good For The Game

more solgov ships good. more energy weapon propaganda, small ship that shouldn't be completely awful.

Testing Photographs and Procedure

Screenshots&Videos

image
image
image
destroyer
frigate

https://github.com/BeeStation/NSV13/assets/55299415/4080afcf-42f2-4fd0-bf8b-2faa735139ca
ship

Changelog

🆑
add: a new shipmap
add: two new solgov ship-sprites
add: a new AI ship for solgov, the VN class frigate, a lighter ship mounting no heavy weaponry, but carries torpedos making it just as dangerous as any other solgov ship
tweak:solgov interdictor has it's own sprite
tweak:changed twoish laser descriptions slightly to respect the setting more
/:cl:

@SerynEngi SerynEngi added Do Not Merge This PR is not ready to be merged yet Work In Progress labels May 20, 2024
@DuskLight9978
Copy link
Contributor

Ping me to this PR when the ships complete as it regards SOLGOV ships

_maps/Vonneumann.json Outdated Show resolved Hide resolved
_maps/Vonneumann.json Outdated Show resolved Hide resolved
_maps/Vonneumann.json Outdated Show resolved Hide resolved
I'm finishing this up
I just want this over at this point
@bluewasabi24
Copy link
Contributor

Admins politely requesting for fax machines, as well.

@@ -0,0 +1,35 @@
{
"map_name": "SGV Von Neumann Mark III",
Copy link
Contributor

@BetaCentari BetaCentari Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:
The name of the ship is a big lengthy to go on the voting board and doesn't follow the ship naming standard. Shortening the title of the ship to SGV Von Neumann for the map_name section in the .json file should be just fine and you can keep the Mark III in the map_description section.

If we can change the description from having references to civilian class or civilian grade to something to indicate standard grade, that'd make a bit more sense as SolGov is a military and governing force. Some examples:

-Remove civilian from point defense fridge so it reads "Von Neumann Class Mark III Point Defense Frigate"
-Civilian Grade Hull could read "Standard Grade Hull"
-Civilian grade defensivei armament could read "Disproportionately large armament for a point defense vessel"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure ok

Copy link
Contributor Author

@Pockets-byte Pockets-byte Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about light hull, since standard grade doesn't really say anything, and it rather, isn't that standard in terms of durability

@someone543
Copy link
Contributor

BotsPatrol

Bots on patrol get stuck and only patrol from one end of this hallway to the other

Screenshot 2025-02-09 104051

Miners don't have access to open the welding tool locker. Mining equipment is also missing a oxygen tank storage

Screenshot 2025-02-09 104155

Mining hangar airlock pressurizes going to space, and depressurizes when going inside

@Pockets-byte
Copy link
Contributor Author

BotsPatrol

Bots on patrol get stuck and only patrol from one end of this hallway to the other

Screenshot 2025-02-09 104051

Miners don't have access to open the welding tool locker. Mining equipment is also missing a oxygen tank storage

Screenshot 2025-02-09 104155

Mining hangar airlock pressurizes going to space, and depressurizes when going inside

Should be fixed now… I hope

@Pockets-byte
Copy link
Contributor Author

image Crates should not be spawning inside of the shuttle doors. Doors on the shuttle should also be shutters, not blast doors, or at least cargo access shuttle doors.

this is unavoidable with a small shuttle- it spawns crates on all open tiles, so short of making the shuttle bigger, I can't fix this

@Bokkiewokkie
Copy link
Contributor

image Crates should not be spawning inside of the shuttle doors. Doors on the shuttle should also be shutters, not blast doors, or at least cargo access shuttle doors.

this is unavoidable with a small shuttle- it spawns crates on all open tiles, so short of making the shuttle bigger, I can't fix this

Just using regular doors will fix it, because they close automatically. The cargo shuttle dock also does not need tiny fans, just having some doors and directional firelocks there is fine enough. (try to avoid tiny fans in mapping)

An unrelated observation. Please make the blue decal line point to Medical, or otherwise install a green line to do so. Command is not really something people struggle (or have a priority) to find, and medical is pretty much the single most important thing to be able to easily find.

@Pockets-byte
Copy link
Contributor Author

image Crates should not be spawning inside of the shuttle doors. Doors on the shuttle should also be shutters, not blast doors, or at least cargo access shuttle doors.

this is unavoidable with a small shuttle- it spawns crates on all open tiles, so short of making the shuttle bigger, I can't fix this

Just using regular doors will fix it, because they close automatically. The cargo shuttle dock also does not need tiny fans, just having some doors and directional firelocks there is fine enough. (try to avoid tiny fans in mapping)

An unrelated observation. Please make the blue decal line point to Medical, or otherwise install a green line to do so. Command is not really something people struggle (or have a priority) to find, and medical is pretty much the single most important thing to be able to easily find.

Done ✔️

@Bokkiewokkie Bokkiewokkie added Needs Test Merge This PR is ready for test merge during a test to determine effectiveness. and removed Active Test Merge labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Update Mapping Needs Test Merge This PR is ready for test merge during a test to determine effectiveness. Sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants