Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update spec to use string instead of enum for ProxyResponseTransform attributes #82

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix: Update spec to use string instead of enum for ProxyResponseTransform attributes #82

merged 3 commits into from
Sep 4, 2024

Conversation

greathouse
Copy link
Contributor

@greathouse greathouse commented Sep 3, 2024 •
edited
Loading

Description

  • Updates based on change from enum to string (Humanize) enums for proxy response transforms.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@greathouse greathouse marked this pull request as ready for review September 3, 2024 20:36
@greathouse greathouse requested a review from a team as a code owner September 3, 2024 20:36
brigonzalez
brigonzalez previously approved these changes Sep 3, 2024
View reviewed changes
@brigonzalez brigonzalez dismissed their stale review September 3, 2024 20:58

need to update go.mod for new breaking change

@greathouse greathouse merged commit 351a82d into master Sep 4, 2024
5 checks passed
@greathouse greathouse deleted the eng-7143-type-matcher-string branch September 4, 2024 13:12
bt-platform-eng pushed a commit that referenced this pull request Sep 4, 2024
@semantic-release-bot
chore(release): 6.0.0 [skip ci]
f8ce48a 
# [6.0.0](v5.2.0...v6.0.0) (2024-09-04)

* fix!: Update spec to use string instead of enum for ProxyResponseTransform attributes (#82) ([351a82d](351a82d)), closes [#82](#82)

### BREAKING CHANGES

* Changes the ProxyTransform type and matcher attributes to string types
@bt-platform-eng
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brigonzalez brigonzalez brigonzalez approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greathouse @bt-platform-eng @brigonzalez