BAH-3416 | Refactor. Optimised code | [Riya/Sweety]

Bahmni · Dec 18, 2023 · 6a8fd2b · 6a8fd2b
1 parent 3d91e8b
commit 6a8fd2b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/...in/java/org/bahmni/module/elisatomfeedclient/api/worker/OpenElisAccessionEventWorker.java b/...in/java/org/bahmni/module/elisatomfeedclient/api/worker/OpenElisAccessionEventWorker.java
@@ -251,14 +251,22 @@ private Obs createObsWith(String textValue, Concept concept, Date obsDateTime) {
     protected Set<Encounter> associateTestResultsToOrder(OpenElisAccession openElisAccession) throws ParseException {
         Encounter orderEncounter = encounterService.getEncounterByUuid(openElisAccession.getAccessionUuid());
 
-        for (OpenElisTestDetail testDetail : openElisAccession.getTestDetails()) {
-            for (Order order : orderEncounter.getOrders()) {
-                if (testDetail != null && order != null && order.getConcept() != null && testDetail.getTestUuid().equals(order.getConcept().getUuid()) && testDetail.getStatus() != null && !testDetail.getStatus().equals("Canceled")) {
-                    order.setAccessionNumber(openElisAccession.getAccessionUuid());
-                    break;
+        if (!orderEncounter.getOrders().isEmpty()) {
+            for (OpenElisTestDetail testDetail : openElisAccession.getTestDetails()) {
+                if (testDetail == null && testDetail.getStatus() == null) {
+                    continue;
+                }
+                for (Order order : orderEncounter.getOrders()) {
+                    if (testDetail.getTestUuid().equals(order.getConcept().getUuid())) {
+                        if ("Canceled".equals(testDetail.getStatus())) {
+                            continue;
+                        }
+                        order.setAccessionNumber(openElisAccession.getAccessionUuid());
+                    }
                 }
             }
         }
+
         final EncounterType labResultEncounterType = getLabResultEncounterType();
         final Set<OpenElisTestDetail> allTests = openElisAccession.getTestDetails();
 

diff --git a/...ava/org/bahmni/module/elisatomfeedclient/api/worker/OpenElisAccessionEventWorkerTest.java b/...ava/org/bahmni/module/elisatomfeedclient/api/worker/OpenElisAccessionEventWorkerTest.java
@@ -1,7 +1,5 @@
 package org.bahmni.module.elisatomfeedclient.api.worker;
 
-import java.util.*;
-
 import org.bahmni.module.elisatomfeedclient.api.Constants;
 import org.bahmni.module.elisatomfeedclient.api.ElisAtomFeedProperties;
 import org.bahmni.module.elisatomfeedclient.api.builder.OpenElisAccessionBuilder;
@@ -32,6 +30,13 @@
 import org.openmrs.module.bahmniemrapi.encountertransaction.command.impl.BahmniVisitAttributeService;
 
 import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
 import java.util.stream.Collectors;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;