Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements: sincos(...) #493

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 2, 2024

Update a few elements to use the sincos function to calculate sin and cos in one go.

Most compilers identify this as an automatic optimization, but we can also make it explicit to be sure.

Update a few elements to use the `sincos` function to calculate `sin`
and `cos` in one go.

Most compilers identify this as an automatic optimization, but we can
also make it explicit to be sure.
@ax3l ax3l added the component: elements Elements/external fields label Jan 2, 2024
@ax3l ax3l requested a review from cemitch99 January 2, 2024 22:30
Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ax3l ax3l merged commit c0a0fa2 into BLAST-ImpactX:development Jan 3, 2024
13 checks passed
@ax3l ax3l deleted the topic-elements-sincos branch January 3, 2024 20:08
Copy link
Member

@n01r n01r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: elements Elements/external fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants