Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for APS-U #27

Merged
merged 54 commits into from
Dec 16, 2024
Merged

Refactor for APS-U #27

merged 54 commits into from
Dec 16, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Dec 4, 2024

@prjemian prjemian added the enhancement New feature or request label Dec 4, 2024
@prjemian prjemian self-assigned this Dec 4, 2024
@coveralls
Copy link

coveralls commented Dec 6, 2024

Pull Request Test Coverage Report for Build 12360646205

Details

  • 770 of 1230 (62.6%) changed or added relevant lines in 16 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+16.2%) to 65.231%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apsbss/apsbss_ophyd.py 27 32 84.38%
apsbss/tests/test_apsbss_list.py 10 20 50.0%
apsbss/tests/test_bss_dm.py 36 48 75.0%
apsbss/bss_dm.py 17 33 51.52%
apsbss/tests/test_apsbss_get.py 4 22 18.18%
apsbss/core.py 149 176 84.66%
apsbss/tests/test_apsbss.py 60 87 68.97%
apsbss/tests/test_bss_is.py 86 142 60.56%
apsbss/tests/test_server_interface.py 44 103 42.72%
apsbss/apsbss.py 33 96 34.38%
Files with Coverage Reduction New Missed Lines %
apsbss/tests/test_apsbss.py 2 78.16%
apsbss/tests/test_apsbss_list.py 3 42.86%
Totals Coverage Status
Change from base Build 12169203498: 16.2%
Covered Lines: 1075
Relevant Lines: 1648

💛 - Coveralls

@prjemian
Copy link
Contributor Author

Code coverage report

coverage run -m pytest -vvv  .
coverage report --precision 3
Name                                    Stmts   Miss    Cover
-------------------------------------------------------------
apsbss/__init__.py                          9      4  55.556%
apsbss/apsbss.py                          207    137  33.816%
apsbss/apsbss_makedb.py                    24      1  95.833%
apsbss/apsbss_ophyd.py                    151     66  56.291%
apsbss/bss_dm.py                           40      0 100.000%
apsbss/bss_is.py                          161     55  65.839%
apsbss/core.py                            152     15  90.132%
apsbss/server_interface.py                143     29  79.720%
apsbss/tests/__init__.py                    0      0 100.000%
apsbss/tests/_core.py                       9      0 100.000%
apsbss/tests/test_apsbss.py               178     30  83.146%
apsbss/tests/test_apsbss_get.py            30      0 100.000%
apsbss/tests/test_apsbss_list.py           70      0 100.000%
apsbss/tests/test_basic.py                  3      0 100.000%
apsbss/tests/test_bss_dm.py                48      1  97.917%
apsbss/tests/test_bss_is.py               142     51  64.085%
apsbss/tests/test_core.py                  95      0 100.000%
apsbss/tests/test_server_interface.py      27      2  92.593%
-------------------------------------------------------------
TOTAL                                    1489    391  73.741%

@prjemian
Copy link
Contributor Author

Coverage now:

coverage report --precision 3
Name                                    Stmts   Miss    Cover
-------------------------------------------------------------
apsbss/__init__.py                          9      4  55.556%
apsbss/apsbss.py                          213     49  76.995%
apsbss/apsbss_makedb.py                    24      1  95.833%
apsbss/apsbss_ophyd.py                    152      5  96.711%
apsbss/bss_dm.py                           40      0 100.000%
apsbss/bss_is.py                          161     55  65.839%
apsbss/core.py                            152     15  90.132%
apsbss/server_interface.py                143      7  95.105%
apsbss/tests/__init__.py                    0      0 100.000%
apsbss/tests/_core.py                      15      0 100.000%
apsbss/tests/conftest.py                   31      0 100.000%
apsbss/tests/test_apsbss.py               167      8  95.210%
apsbss/tests/test_apsbss_get.py            30      0 100.000%
apsbss/tests/test_apsbss_list.py           70      0 100.000%
apsbss/tests/test_apsbss_ophyd.py          33      0 100.000%
apsbss/tests/test_bss_dm.py                48      1  97.917%
apsbss/tests/test_bss_is.py               142     51  64.085%
apsbss/tests/test_core.py                  95      0 100.000%
apsbss/tests/test_server_interface.py      90      3  96.667%
-------------------------------------------------------------
TOTAL                                    1615    199  87.678%

@prjemian
Copy link
Contributor Author

Latest local code coverage test at APS (where tests with actual servers are possible):

$ coverage report --precision 3
Name                                    Stmts   Miss    Cover
-------------------------------------------------------------
apsbss/__init__.py                          9      4  55.556%
apsbss/apsbss.py                          213     45  78.873%
apsbss/apsbss_makedb.py                    24      1  95.833%
apsbss/apsbss_ophyd.py                    152      6  96.053%
apsbss/bss_dm.py                           33      0 100.000%
apsbss/bss_is.py                          155     27  82.581%
apsbss/core.py                            176     14  92.045%
apsbss/server_interface.py                143      7  95.105%
apsbss/tests/__init__.py                    0      0 100.000%
apsbss/tests/_core.py                      15      0 100.000%
apsbss/tests/conftest.py                   33      0 100.000%
apsbss/tests/test_apsbss.py               174      9  94.828%
apsbss/tests/test_apsbss_get.py            30      0 100.000%
apsbss/tests/test_apsbss_list.py           70      0 100.000%
apsbss/tests/test_apsbss_ophyd.py          33      0 100.000%
apsbss/tests/test_bss_dm.py                48      1  97.917%
apsbss/tests/test_bss_is.py               142      9  93.662%
apsbss/tests/test_core.py                  95      0 100.000%
apsbss/tests/test_server_interface.py     103      9  91.262%
-------------------------------------------------------------
TOTAL                                    1648    132  91.990%

@prjemian prjemian merged commit 7779183 into main Dec 16, 2024
6 checks passed
@prjemian prjemian deleted the 14-APSU-refactor branch December 16, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interface with new APS scheduling system BUG: no documentation for apsbss_ophyd
2 participants