Cancel Phoenix container allocation on ctrl+c & ctrl+z #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2025 12:47
…o users/aisayas/cassandra-shell-msrc
added 2 commits
February 12, 2025 12:56
jawelton74
reviewed
Feb 12, 2025
src/Phoenix/PhoenixClient.ts
Outdated
| this.abortSignal = this.abortController.signal; | ||
|
|
||
| document.addEventListener("keydown", (event: KeyboardEvent) => { | ||
| if (event.ctrlKey && event.key === "c") { |
There was a problem hiding this comment.
Shouldn't we be listening for Ctrl+D as well ?
There was a problem hiding this comment.
I could not reproduce with Ctrl+D on Chrome and Edge. That command adds a bookmark.
asier-isayas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview this branch
This PR is to cancel the Mongo shell operations when user presses CTRL+C & CTRL+Z.