-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update avm/res/service-bus/namespace
- Add support for AKV secrets export
#4287
base: main
Are you sure you want to change the base?
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
avm/res/service-bus/namespace/tests/e2e/kvSecrets/main.test.bicep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @weikanglim - content-wise nothing to complain about at all. The suggestions I added were all just minor details to align with the spec, address a very new bicep warning & format the export file 💪
Please note: After commiting the changes (which you can do via the GitHub UI) you'll have to re-run the Set-AVMModule --Path '(...)' Recurse
function to regenerate the readme & json files. Thank you
avm/res/service-bus/namespace
- Add support for AKV secrets export
Thank you for the updates @weikanglim, I'll leave the final review to the module's owner @ChrisSidebotham 💪 |
Hey @ChrisSidebotham , let me know if this looks good to you ! Thanks for reviewing |
Description
Closes #3638
Pipeline Reference
Verified locally:
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.