Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Add support to configure DiskControllerTypes for avm/res/compute/gallery #4349

Open
1 task done
CTOUT opened this issue Jan 30, 2025 · 3 comments
Open
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@CTOUT
Copy link

CTOUT commented Jan 30, 2025

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/compute/gallery

(Optional) Module Version

0.8.2

Description

Similar to #3813, the support to define DiskControllerTypes is missing.
As a result, the VM SKUs that support NVMe cannot be used.

Azure Portal JSON (VM image definition)

"features": [
            {
                "name": "SecurityType",
                "value": "TrustedLaunchSupported"
            },
            {
                "name": "DiskControllerTypes",
                "value": "SCSI, NVMe"
            }
        ],

BICEP (avm/res/compute/gallery:0.8.2)

    images: [
      {
        name: imagesSharedGalleryName
        identifier: {
          publisher: publisherName
          offer: offerName
          sku: skuVersion
        }
        osType: 'Windows'
        osState: 'Generalized'
        hyperVGeneration: 'V2'
        securityType: 'TrustedLaunch'
        diskcontrollerType: 'NVMe'
      }
    ]

The property "diskcontrollerType" is not allowed on objects of type "{ name: string, description: null | string, osType: 'Linux' | 'Windows', osState: 'Generalized' | 'Specialized', identifier: identifierType, vCPUs: resourceRangeType, memory: resourceRangeType, hyperVGeneration: 'V1' | 'V2' | null, securityType: 'ConfidentialVM' | 'ConfidentialVMSupported' | 'Standard' | 'TrustedLaunch' | 'TrustedLaunchAndConfidentialVmSupported' | 'TrustedLaunchSupported' | null, isAcceleratedNetworkSupported: bool | null, isHibernateSupported: bool | null, architecture: 'Arm64' | 'x64' | null, eula: null | string, privacyStatementUri: null | string, releaseNoteUri: null | string, purchasePlan: purchasePlanType, endOfLife: null | string, excludedDiskTypes: null | string[] }". Permissible properties include "architecture", "description", "endOfLife", "eula", "excludedDiskTypes", "isAcceleratedNetworkSupported", "isHibernateSupported", "memory", "privacyStatementUri", "purchasePlan", "releaseNoteUri", "vCPUs".bicepBCP037

(Optional) Correlation Id

No response

@CTOUT CTOUT added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 30, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Copy link

@CTOUT, thanks for submitting this issue for the avm/res/compute/gallery module!

Important

A member of the @Azure/avm-res-compute-gallery-module-owners-bicep or @Azure/avm-res-compute-gallery-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Status: Needs: Triage
Development

No branches or pull requests

2 participants