Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: add /metrics endpoint #1419

Merged
merged 1 commit into from
Feb 28, 2025
Merged

backend: add /metrics endpoint #1419

merged 1 commit into from
Feb 28, 2025
+204 −34

Conversation

simonpasquier
Copy link
Collaborator

What this PR does

Jira:
Link to demo recording:

Special notes for your reviewer

@github-actions GitHub Actions
Copy link

Please rebase pull request.

simonpasquier
simonpasquier commented Feb 27, 2025
View reviewed changes
backend/deploy/helm/backend/templates/peerauthentication.yaml
@@ -0,0 +1,11 @@
apiVersion: security.istio.io/v1beta1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is similar to #1420

mbarnes
mbarnes requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. This sets the stage nicely for also adding a /healthz endpoint with leader-election integration.

I had one suggestion, but not a requirement if you don't like it or it wouldn't work.

mbarnes
mbarnes requested changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Had a further suggestion but, again, not required.

@simonpasquier
backend: add /metrics endpoint
1b1b8c5 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@mbarnes mbarnes merged commit 3f13146 into main Feb 28, 2025
22 checks passed
@mbarnes mbarnes deleted the add-backend-metrics branch February 28, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarnes mbarnes mbarnes approved these changes

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@venkateshsredhat venkateshsredhat Awaiting requested review from venkateshsredhat venkateshsredhat is a code owner

@Nanyte25 Nanyte25 Awaiting requested review from Nanyte25 Nanyte25 is a code owner

@kostola kostola Awaiting requested review from kostola kostola is a code owner

@DennisJWheeler DennisJWheeler Awaiting requested review from DennisJWheeler DennisJWheeler is a code owner

@hbhushan3 hbhushan3 Awaiting requested review from hbhushan3 hbhushan3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonpasquier @mbarnes