frontend: refactor metrics #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpasquier
force-pushed
the
refactor-frontend-http-metrics
branch
from
39d876d to
7966ad8
Compare
|
Please rebase pull request. |
simonpasquier
force-pushed
the
refactor-frontend-http-metrics
branch
from
7966ad8 to
f991ced
Compare
simonpasquier
requested review from
bennerv,
mbarnes,
SudoBrendan,
mociarain,
venkateshsredhat,
Nanyte25,
kostola,
DennisJWheeler and
hbhushan3
as code owners
|
Tested in my dev environment in conjunction with #1420
|
mbarnes
requested changes
Feb 27, 2025
| } | ||
|
|
||
| func (c *ContextError) Error() string { | ||
| return fmt.Sprintf( | ||
| "error retrieving value from context, value obtained was '%v' and type obtained was '%T'", | ||
| "error retrieving value for key %q from context, value obtained was '%v' and type obtained was '%T'", | ||
| c.key, |
There was a problem hiding this comment.
Appreciate the refactoring of the context API. I won't ask for it this time but in the future it would be good to split refactoring into one or more focused commits for easier review. There's a lot packed into this one commit.
There was a problem hiding this comment.
Right, I got a bit too enthusiastic here.
This commit refactors the frontend service to report more sensible and useful metrics. The visible changes are: * The `endpoint` label of the `frontend_health` gauge metric is dropped. * The `frontend_requests_total` gauge metric is renamed to `frontend_http_requests_total` (counter). * The `frontend_duration` gauge metric is renamed to `frontend_http_requests_duration_seconds` (histogram). The histogram buckets have been chosen to match the MSFT requirements in terms of latency: [0.25s, 0.5s, 1s, 2.5s, 5s, 10s]. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
refactor-frontend-http-metrics
branch
from
f991ced to
4e0f4c2
Compare
mbarnes
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This commit refactors the frontend service to report more sensible and useful metrics.
The visible changes are:
endpointlabel of thefrontend_healthgauge metric is dropped.frontend_requests_totalgauge metric is renamed tofrontend_http_requests_total(counter).frontend_durationgauge metric is renamed tofrontend_http_requests_duration_seconds(histogram).The histogram buckets have been chosen to match the MSFT requirements in terms of latency: [0.25s, 0.5s, 1s, 2.5s, 5s, 10s].
Jira:
Link to demo recording:
Special notes for your reviewer