Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Remove External Auth #1404

Merged
merged 1 commit into from
Feb 28, 2025
Merged

[API] Remove External Auth #1404

merged 1 commit into from
Feb 28, 2025

Conversation

jonathan34c
Copy link
Contributor

What this PR does

Remove External Auth per API review doc : https://docs.google.com/document/d/1k6sqn7uFe46pnweQU_BPu07ux6U_gAiZPVYdGKKCKww/edit?tab=t.0
JIRA ticket:
https://issues.redhat.com/browse/ARO-15336

Fields that I removed

ExternalAuthConfigProfile
ExternalAuthProfile
TokenIssuerProfile
ExternalAuthClientProfile
ExternalAuthClaimProfile
ExternalAuthClientComponentProfile
TokenClaimMappingsProfile
TokenClaimValidationRuleProfile
ClaimProfile

Jira:
Link to demo recording:

Special notes for your reviewer

Copy link

Please rebase pull request.

Copy link

Please rebase pull request.

@jonathan34c jonathan34c force-pushed the jonachang/exauth branch 2 times, most recently from 24b069f to 3ccd120 Compare February 26, 2025 18:19
@jonathan34c jonathan34c force-pushed the jonachang/exauth branch 2 times, most recently from 624f3f2 to 6793a0c Compare February 26, 2025 19:12
@jonathan34c jonathan34c marked this pull request as ready for review February 26, 2025 20:59
Copy link

Please rebase pull request.

…ExternalAuthConfigProfile

ExternalAuthProfile
TokenIssuerProfile
ExternalAuthClientProfile
ExternalAuthClaimProfile
ExternalAuthClientComponentProfile
TokenClaimMappingsProfile
TokenClaimValidationRuleProfile
ClaimProfile
Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that one gone. Thanks!

@mbarnes mbarnes merged commit f6105d1 into main Feb 28, 2025
23 checks passed
@mbarnes mbarnes deleted the jonachang/exauth branch February 28, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants