frontend dns record #1401
Merged
frontend dns record #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
requested review from
bennerv,
janboll,
jmelis,
jonathan34c,
SudoBrendan,
UlrichSchlueter,
weinong,
whober0521,
tony-schndr,
jfchevrette,
mmazur and
stevekuznetsov
as code owners
geoberle
force-pushed
the
frontend-dns
branch
3 times, most recently
from
a403cba to
d302094
Compare
geoberle
force-pushed
the
frontend-dns
branch
from
d302094 to
62692e0
Compare
janboll
previously approved these changes
Feb 27, 2025
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
geoberle
force-pushed
the
frontend-dns
branch
2 times, most recently
from
1cb04d9 to
4c04a5a
Compare
geoberle
commented
Feb 28, 2025
| @@ -158,7 +158,7 @@ module maestroInfra '../modules/maestro/maestro-infra.bicep' = { | |||
| maxClientSessionsPerAuthName: maestroEventGridMaxClientSessionsPerAuthName | |||
| publicNetworkAccess: maestroEventGridPrivate ? 'Disabled' : 'Enabled' | |||
| certificateIssuer: maestroCertificateIssuer | |||
| logAnalyticsWorkspaceId: logAnalyticsWorkspace.id | |||
| logAnalyticsWorkspaceId: enableLogAnalytics ? logAnalyticsWorkspace.id : '' | |||
geoberle
force-pushed
the
frontend-dns
branch
from
4c04a5a to
c40c383
Compare
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
geoberle
force-pushed
the
frontend-dns
branch
from
327ecdf to
9c310e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
introduce a DNS record for frontend on top of the SVC cluster istio ingress gateway public IP
follows up on #1201
@katherinelc321 PTAL
Jira: https://issues.redhat.com/browse/ARO-14845
Link to demo recording:
Special notes for your reviewer