Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Remove etcdencryption and etcdencryptionsetid #1397

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

jonathan34c
Copy link
Contributor

…implement in the future

What this PR does

Remove ClusterSpec.Proxy, ClusterPatchSpec.Proxy and child resources, may be re-added in the future.
API review doc :https://docs.google.com/document/d/1k6sqn7uFe46pnweQU_BPu07ux6U_gAiZPVYdGKKCKww/edit?tab=t.0#heading=h.7zb8p6a16n2r
Jira Ticket: https://issues.redhat.com/browse/ARO-15335

Jira:
Link to demo recording:

Special notes for your reviewer

@jonathan34c jonathan34c force-pushed the jonachang/etcd branch 2 times, most recently from 1c741b9 to 0827223 Compare February 24, 2025 22:27
@jonathan34c jonathan34c changed the title Remove etcdencryption and etcdencryptionsetid [API] Remove etcdencryption and etcdencryptionsetid Feb 24, 2025
@jonathan34c jonathan34c marked this pull request as ready for review February 25, 2025 21:02
Copy link
Collaborator

@SudoBrendan SudoBrendan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mbarnes mbarnes enabled auto-merge February 26, 2025 17:48
@mbarnes
Copy link
Collaborator

mbarnes commented Feb 26, 2025

All the go mod tidy crud is blocking me from merging. You might try rebasing this on the latest main revision to see if those changes get removed. Otherwise you'll have to ask one of the listed code owners with write access.

@mbarnes mbarnes merged commit a044e0f into main Feb 26, 2025
11 checks passed
@mbarnes mbarnes deleted the jonachang/etcd branch February 26, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants