Remove proxy and child resources, might added back in the future #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan34c
force-pushed
the
jonachang/proxy3
branch
from
f474924 to
b91afe0
Compare
jonathan34c
force-pushed
the
jonachang/proxy3
branch
from
b91afe0 to
0699486
Compare
geoberle
reviewed
Feb 24, 2025
Comment on lines
-112
to
-124
| proxyConfig: | ||
| description: ProxyConfig defines the cluster-wide proxy configuration of the OCP managed cluster. | ||
| properties: | ||
| httpProxy: | ||
| description: HTTPProxy is the URL of the proxy for HTTP requests. Empty means unset and will not result in an env var. | ||
| type: string | ||
| httpsProxy: | ||
| description: HTTPSProxy is the URL of the proxy for HTTPS requests. Empty means unset and will not result in an env var. | ||
| type: string | ||
| noProxy: | ||
| description: NoProxy is a comma-separated list of hostnames and/or CIDRs for which the proxy should not be used. Empty means unset and will not result in an env var. The API Server of Hub cluster should be added here. And If you scale up workers that are not included in the network defined by the networking.machineNetwork[].cidr field from the installation configuration, you must add them to this list to prevent connection issues. | ||
| type: string | ||
| type: object |
There was a problem hiding this comment.
i know you have closed this PR but for future reference: the manifests in the acm/deploy folder are autogenerated from Red Hat release manifests of ACM so modifying them here would not be persisted as this fiels are generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer