frontend: fix tests using httptest.ResponseRecorder #1378
Merged
+74
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpasquier
requested review from
bennerv,
mbarnes,
SudoBrendan,
mociarain,
venkateshsredhat,
Nanyte25,
kostola and
hbhushan3
as code owners
mbarnes
requested changes
Feb 24, 2025
simonpasquier
force-pushed
the
refactor-middleware-tests
branch
2 times, most recently
from
fec522f to
f13c96c
Compare
simonpasquier
requested review from
geoberle,
janboll,
weinong,
whober0521,
tony-schndr and
jfchevrette
as code owners
simonpasquier
force-pushed
the
refactor-middleware-tests
branch
from
f13c96c to
0debdfd
Compare
|
Thanks! PR rebased and fixed. |
mbarnes
approved these changes
Feb 24, 2025
|
All the dependabot gunk that got added here is preventing me from merging. You might try rebasing on |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
refactor-middleware-tests
branch
from
0debdfd to
d804183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Follow-up of #1305. There's no functional change (only the tests are updated).
Jira:
Link to demo recording:
Special notes for your reviewer