Support & enable audit logging for Key Vault and AKS for dev & cspr environments #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfchevrette
force-pushed
the
dev-audit-logging
branch
from
848b27a to
d6eb403
Compare
jfchevrette
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
jmelis,
jonathan34c,
SudoBrendan and
UlrichSchlueter
as code owners
jfchevrette
force-pushed
the
dev-audit-logging
branch
2 times, most recently
from
581d86e to
c55bc6c
Compare
tony-schndr
reviewed
Feb 24, 2025
geoberle
reviewed
Feb 24, 2025
jfchevrette
force-pushed
the
dev-audit-logging
branch
from
bea4e40 to
75ca2cf
Compare
Added in 75ca2cf |
geoberle
previously approved these changes
Feb 24, 2025
jfchevrette
force-pushed
the
dev-audit-logging
branch
from
75ca2cf to
d8729c3
Compare
|
Please rebase pull request. |
jfchevrette
force-pushed
the
dev-audit-logging
branch
from
d8729c3 to
7a326dd
Compare
|
Please rebase pull request. |
jfchevrette
force-pushed
the
dev-audit-logging
branch
from
7a326dd to
e2c8c4e
Compare
jfchevrette
force-pushed
the
dev-audit-logging
branch
from
e2c8c4e to
4251dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
log.enableLogAnalytics- defaults to false, true for dev and cspr)Diagnostic DettingsWhy
These logs are being enabled only for dev/cspr environments to help with troubleshooting. Int, stage and production will use a different logging mechanism that is only available in EV2
Jira:
Special notes for your reviewer
Suggest reviewing commit by commit