Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARO-15333] remove fips from #1370

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[ARO-15333] remove fips from #1370

merged 1 commit into from
Feb 20, 2025

Conversation

jonathan34c
Copy link
Contributor

@jonathan34c jonathan34c commented Feb 19, 2025

What this PR does

Per https://docs.google.com/document/d/1k6sqn7uFe46pnweQU_BPu07ux6U_gAiZPVYdGKKCKww/edit?tab=t.0#heading=h.7zb8p6a16n2r, remove ClusterSpec.FIPS
Remove ClusterSpec.fips - not required until August timeline

Jira: ARO-15333 - API Cleanup: Remove FIPS
Link to demo recording:

Special notes for your reviewer

@stevekuznetsov
Copy link
Contributor

I can't access that Google doc. Could we please get in the habit of clearly explaining why we're making a change such as this in the Git commit message? It will auto-fill the GitHub PR description. I would like to know - what is the reason? Is it not possible to support this on Azure? Are we deferring this until a later point? When should we reconsider?

Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes to aks-cluster-base-bicep. Otherwise good to go.

Also thanks for dividing this into one field-removal per commit. It will make it easier to restore individual API fields in the future should we need to.

@mbarnes
Copy link
Collaborator

mbarnes commented Feb 20, 2025

I can't access that Google doc. Could we please get in the habit of clearly explaining why we're making a change such as this in the Git commit message? It will auto-fill the GitHub PR description.

👍
@stevekuznetsov I asked @SudoBrendan to grant you access to the Google doc. These are outcomes from our recent internal ARM API review where it was decided to remove several cluster API fields, at least temporarily. This PR will be the first of several like it. Also I linked to the relevant JIRA story in the description, though it says the same as what Jonathan pasted.

@mbarnes mbarnes merged commit 3f60f9d into main Feb 20, 2025
23 checks passed
@mbarnes mbarnes deleted the jonachang/fips branch February 20, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants