database: Add ManagedServiceIdentity struct to ResourceDocument #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cluster Service holds the user-assigned identities that are present
in the top-level "identity" section of a cluster resource, but the
other fields of that section were being lost.
Currently the other "identity" fields should have
"identity": {
"principalId": "",
"tenantId": "",
"type": "UserAssigned"
}
but we should not be assuming this.
The RP is required to include the top-level "identity" section in
full when returning a cluster resource in a response body. There-
fore we will stash these remaining "identity" fields in Cosmos DB
alongside the Azure system metadata and resource tags.
mbarnes
requested review from
bennerv,
SudoBrendan,
mociarain,
venkateshsredhat,
Nanyte25,
kostola and
hbhushan3
as code owners
SudoBrendan
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Cluster Service holds the user-assigned identities that are present in the top-level "identity" section of a cluster resource, but the other fields of that section were being lost.
Currently the other "identity" fields should have
but we should not be assuming this.
The RP is required to include the top-level "identity" section in full when returning a cluster resource in a response body. Therefore we will stash these remaining "identity" fields in Cosmos DB alongside the Azure system metadata and resource tags.
Jira: no Jira; observed during testing