refactor csv string parameter handling - fix empty string to array split #1362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
split
when passed an empty string, will return an array with the empty string as the first element, even if there were no occurrences of the split delimiter. In our use case, we actually want no items in the array if there were no items in the string (empty string should be considered no item)This current breaks the case when no availability zones are passed (either by the use of an empty array or by passing an empty string)
Example showing what happens
The change improves the param description and adds helper functions which help clarify the intent and makes it reusable
Jira:
Link to demo recording:
Special notes for your reviewer