ensure AKS managed RG has perist:true tag #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
requested review from
bennerv,
janboll,
jmelis,
jonathan34c,
SudoBrendan,
UlrichSchlueter,
weinong,
whober0521,
tony-schndr and
jfchevrette
as code owners
|
Please rebase pull request. |
an AKS clusters RG inherits the tags of the AKS resource itself. but even if an ARO HCP environment is set up with `persist: false`, the managed RG of the AKS clusters should not be touched by our RG cleanup job as they are lifecycled together with their AKS cluster anyways. therefore we will set `persist:true` on all AKS clusters we create, regardless of the nature of the environment. Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
geoberle
force-pushed
the
persist-aks
branch
from
bb20a6d to
c0e1da1
Compare
jfchevrette
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
an AKS clusters RG inherits the tags of the AKS resource itself. but even if an ARO HCP environment is set up with
persist: false, the managed RG of the AKS clusters should not be touched by our RG cleanup job as they are lifecycled together with their AKS cluster anyways.therefore we will set
persist:trueon all AKS clusters we create, regardless of the nature of the environment.Jira:
Link to demo recording:
Special notes for your reviewer