Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maestro support onecert client certificates #1298

Merged
merged 3 commits into from
Feb 11, 2025
Merged

maestro support onecert client certificates #1298

merged 3 commits into from
Feb 11, 2025

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented Feb 11, 2025 •
edited
Loading

What this PR does

while we keep self-signed certificates in DEV, we will switch to onecert in higher envs

  • introduce maestro.certIssuer configuration option
  • introduce maestro.certDomain is now optional and defaults to maestro.${regionalsvc}
  • dev still sets the certdomain to make sure it does not change for now in integrated DEV where we can't have a change in certs for maestro due to current debugging efforts (we can remove the config option in a follow up PR and only use the default)

Jira: https://issues.redhat.com/browse/ARO-14933
Link to demo recording:

Special notes for your reviewer

@geoberle geoberle force-pushed the maestro-onecert branch 3 times, most recently from 96f8866 to d63212b Compare February 11, 2025 10:21
jfchevrette
jfchevrette previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@jfchevrette jfchevrette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple suggestions and a question, otherwise LGTM

janboll
janboll previously approved these changes Feb 11, 2025
View reviewed changes
@geoberle @jfchevrette
Update dev-infrastructure/templates/mgmt-cluster.bicep
f004fbf 
Co-authored-by: Jean-Francois Chevrette <jchevret@redhat.com>
@geoberle geoberle dismissed stale reviews from janboll and jfchevrette via f004fbf February 11, 2025 15:09
@geoberle @jfchevrette
Update dev-infrastructure/templates/svc-cluster.bicep
e1aed32 
Co-authored-by: Jean-Francois Chevrette <jchevret@redhat.com>
@geoberle geoberle merged commit 92d2f37 into main Feb 11, 2025
22 checks passed
@geoberle geoberle deleted the maestro-onecert branch February 11, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfchevrette jfchevrette jfchevrette left review comments

@janboll janboll janboll left review comments

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@weinong weinong Awaiting requested review from weinong weinong is a code owner

@whober0521 whober0521 Awaiting requested review from whober0521 whober0521 is a code owner

@tony-schndr tony-schndr Awaiting requested review from tony-schndr tony-schndr is a code owner

@jmelis jmelis Awaiting requested review from jmelis jmelis is a code owner

@jonathan34c jonathan34c Awaiting requested review from jonathan34c jonathan34c is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoberle @jfchevrette @janboll