frontend: refactor subscription metrics #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpasquier
requested review from
bennerv,
mbarnes,
SudoBrendan,
mociarain,
venkateshsredhat,
Nanyte25,
kostola and
hbhushan3
as code owners
|
Please rebase pull request. |
simonpasquier
force-pushed
the
lifecycle-metric-collector
branch
from
0b03196 to
d8e71bf
Compare
|
Please rebase pull request. |
simonpasquier
force-pushed
the
lifecycle-metric-collector
branch
from
d8e71bf to
195c66b
Compare
simonpasquier
force-pushed
the
lifecycle-metric-collector
branch
from
195c66b to
40d29db
Compare
mbarnes
requested changes
Feb 10, 2025
simonpasquier
force-pushed
the
lifecycle-metric-collector
branch
from
40d29db to
acc859e
Compare
This change implements a custom collector for the subscription lifecycle metrics. In practice, the collector maintains a local cache of subscriptions which is refreshed periodically from the database. The benefits are: * The metrics are persisted upon restart of the process (previously a subscription would only exist as a metric if it was accessed by some HTTP operation). * All frontend replicas report the same metrics. * Only the latest state of a subscription is reported (in the previous implementation, the old state would still be reported after an update). The cache is refreshed every 30 seconds which should be good enough assuming that the metrics are scraped at a similar (or greater) interval. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
lifecycle-metric-collector
branch
from
acc859e to
3c9fbb1
Compare
mbarnes
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Very nice!
This will introduce a small conflict with changes I have staged in #1215 - database: Merge Cosmos DB containers but I'll adapt it rather than hold this PR up any longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This change implements a custom collector for the subscription lifecycle metrics. In practice, the collector maintains a local cache of subscriptions which is refreshed periodically from the database.
The benefits are:
The cache is refreshed every 30 seconds which should be good enough assuming that the metrics are scraped at a similar (or greater) interval.
Jira:
Link to demo recording:
Special notes for your reviewer