Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARO-9420: *: add acrpull controller, binding #1011

Merged
merged 3 commits into from
Jan 9, 2025
Merged

ARO-9420: *: add acrpull controller, binding #1011

merged 3 commits into from
Jan 9, 2025

Conversation

stevekuznetsov
Copy link
Contributor

Supersedes #986

@stevekuznetsov
Copy link
Contributor Author 

Error: failed linting charts: failed processing charts
 ✖︎ frontend => (version: "0.1.0", path: "frontend/deploy/helm/frontend") > failed waiting for process: exit status 1

??

@stevekuznetsov stevekuznetsov force-pushed the skuznets/acrpull branch 3 times, most recently from a234856 to a6d978d Compare December 19, 2024 21:02
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Please rebase pull request.

@stevekuznetsov
Copy link
Contributor Author

@geoberle not sure if GitHub will be happy with a fast-forward but this PR is rebased on top of #1065 now

stevekuznetsov and others added 3 commits January 9, 2025 06:28
@stevekuznetsov
*: add acrpull binding to RP
5fccdf6 
Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
@geoberle @stevekuznetsov
various fixes and updates
f565713 
- updated msi pull controller to 0.1.7
- updated pull binding CRD for the additional workload identity fields
- updated podmonitor to use the az apigroup (we don't have core prometheus CRDs installed)
- updated VAP parameterNotFoundAction to `Allow` to mitigate a potential bug
- updated servicegroup name in pipeline.yaml for acrpull
- serialize image-puller MI federation setup (only one update at a time is supported)

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
@stevekuznetsov
dev-infrastructure: parallelize fmt, lint
ec8553a 
Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
@stevekuznetsov
Copy link
Contributor Author

GitHub was not, in fact, happy - so rebased.

mbarnes
mbarnes approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the extent I understand this, it looks good to me.

@stevekuznetsov
Copy link
Contributor Author

@mbarnes please ask any questions you have!

@bennerv bennerv merged commit 44f1d35 into main Jan 9, 2025
21 checks passed
@bennerv bennerv deleted the skuznets/acrpull branch January 9, 2025 14:35
mbarnes pushed a commit that referenced this pull request Feb 15, 2025
backend: Make Makefile image variables consistent with frontend
8113d01 
The image variables in frontend/Makefile changed recently in
#1011

This just makes backend/Makefile use consistent variable names.
@mbarnes mbarnes mentioned this pull request Feb 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarnes mbarnes mbarnes approved these changes

@geoberle geoberle geoberle approved these changes

@bennerv bennerv bennerv approved these changes

@janboll janboll Awaiting requested review from janboll janboll is a code owner

@weinong weinong Awaiting requested review from weinong weinong is a code owner

@whober0521 whober0521 Awaiting requested review from whober0521 whober0521 is a code owner

@tony-schndr tony-schndr Awaiting requested review from tony-schndr tony-schndr is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@jmelis jmelis Awaiting requested review from jmelis jmelis is a code owner

@jonathan34c jonathan34c Awaiting requested review from jonathan34c jonathan34c is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22

@zgalor zgalor Awaiting requested review from zgalor

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@venkateshsredhat venkateshsredhat Awaiting requested review from venkateshsredhat venkateshsredhat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevekuznetsov @mbarnes @geoberle @bennerv