add mce clusterlifecycle-state-metrics #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-schndr
force-pushed
the
clc-state-metrics
branch
from
33898e0 to
e889b04
Compare
tony-schndr
force-pushed
the
clc-state-metrics
branch
from
45c9cb4 to
35eb9ce
Compare
tony-schndr
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
jharrington22,
SudoBrendan,
UlrichSchlueter and
zgalor
as code owners
geoberle
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds metrics for ACM/MCE by deploying the
clusterlifecycle-state-metricsvia a helm chart. This component would normally be deployed through the MCE however it is disabled on aks clusters in version 2.7, so this helm chart is a way to bypass that. Once MCE version 2.8 is release we can uninstall this helm chart and install the component through the MCE.The upstream helm chart - https://github.com/stolostron/mce-install-kube/tree/main/clc-state-metrics
NOTE: This chart is ignored by the yaml linter because some of the helm template constructs don't follow yaml, which should be fine considering this helm chart is temporary till mce 2.8 is available.
Jira: https://issues.redhat.com/browse/ARO-10135
Link to demo recording:
Special notes for your reviewer