Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note on sampling #78

Merged
merged 3 commits into from
Jan 29, 2025
Merged

add note on sampling #78

merged 3 commits into from
Jan 29, 2025

Conversation

lucashuet93
Copy link
Contributor

Purpose

  • add note on sampling and how to update the value

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

@lucashuet93 lucashuet93 self-assigned this Jan 28, 2025
@lucashuet93 lucashuet93 force-pushed the lucashh/sampling-note branch from 3700fc0 to 9d9f411 Compare January 28, 2025 15:01
Copy link
Contributor

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is it worth adding an issue for updating capabilities to emit metrics and use those for verification in the end-to-end tests?

@lucashuet93
Copy link
Contributor Author

@stuartleeks created!

@lucashuet93 lucashuet93 merged commit eed4c7e into main Jan 29, 2025
2 checks passed
@lucashuet93 lucashuet93 deleted the lucashh/sampling-note branch January 29, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants