Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe Config Card to extract blocks from items containing items (such as Banks from Bank Storage) #1022

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

Swedz
Copy link
Collaborator

@Swedz Swedz commented Feb 9, 2025

A few things to comment on:

  • The camouflage applying is now done entirely server-side, since item handler capabilities shouldn't be messed with on the client side. In the case of Bank Storage, they use a read-only item handler capability on the client side. Because of this, the "No _____ in inventory" actionbar was being displayed and sounds wouldn't always play because the client got a different result when extracting than the server did.

  • TransferHelper#extractMatching had to get adjusted to allow for recursive item extracting.

    • It won't go any deeper than one level though, so no backpacks inside backpacks - for example. This might be worth changing? Would be as simple as passing true to the recursive calls.

    • ItemStack#matches checks against item count which is (likely?) not intended here, changed it to ItemStack#isSameItemSameComponents to retain functionality while also fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant