v2.4.7

Use '*' instead of 'auto' for full-width tables (see #151)
Aymkdn · Oct 10, 2022 · 74b592f · 74b592f
1 parent 21995fd
commit 74b592f
Show file tree

Hide file tree

Showing 10 changed files with 49 additions and 14 deletions.
diff --git a/.github/no-response.yml b/.github/no-response.yml
diff --git a/.github/workflows/needs-reply-remove.yml b/.github/workflows/needs-reply-remove.yml
@@ -0,0 +1,23 @@
+name: Remove needs-reply label
+
+on:
+  issue_comment:
+    types:
+      - created
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Remove needs-reply label
+        uses: octokit/request-action@v2.x
+        continue-on-error: true
+        with:
+          route: DELETE /repos/:repository/issues/:issue/labels/:label
+          repository: ${{ github.repository }}
+          issue: ${{ github.event.issue.number }}
+          label: waiting-for-requestor
+          days-before-close: 3
+          close-message: This issue has been automatically closed because the requestor didn't provide any additional comment.
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/needs-reply.yml b/.github/workflows/needs-reply.yml
@@ -0,0 +1,18 @@
+name: Close old issues that need reply
+
+on:
+  issues:
+    types:
+      - labeled
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Close old issues that need reply
+        uses: dwieeb/needs-reply@v2
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          issue-label: waiting-for-requestor
+          days-before-close: 1
+          close-message: This issue has been automatically closed because the requestor didn't provide any additional comment.
diff --git a/browser.js b/browser.js
diff --git a/docs/browser-2.4.5.js b/docs/browser-2.4.5.js
diff --git a/docs/browser-2.4.7.js b/docs/browser-2.4.7.js
diff --git a/docs/index.html b/docs/index.html
@@ -116,7 +116,7 @@ <h1>HTML to PDFMake convertor</h1>
       <div id="pdf_ie" style="display:none;padding:3em">The PDF file is sent to you for download. Use a modern browser (like Chrome or Firefox) to display the PDF in this page.</div>
     </div>
   </div>
-  <script src="browser-2.4.5.js"></script>
+  <script src="browser-2.4.7.js"></script>
   <script src="https://cdn.jsdelivr.net/npm/pdfmake@latest/build/pdfmake.min.js"></script>
   <script src="https://cdn.jsdelivr.net/npm/pdfmake@latest/build/vfs_fonts.js"></script>
   <script>

diff --git a/example.pdf b/example.pdf
diff --git a/index.js b/index.js
@@ -303,7 +303,10 @@ function htmlToPdfMake(htmlText, options) {
               if (tableWidths.length > 0) {
                 // if all columns are in 'auto' and if we have 'width:"100%"' for the table
                 // then put widths:['*', '*' …], for all columns
-                if (fullWidth && tableWidths.filter(function(w) { return w==='auto' }).length === tableWidths.length) tableWidths=tableWidths.map(function() { return '*' });
+                //if (fullWidth && tableWidths.filter(function(w) { return w==='auto' }).length === tableWidths.length) tableWidths=tableWidths.map(function() { return '*' });
+                // see https://github.com/Aymkdn/html-to-pdfmake/issues/151#issuecomment-1273015585
+                // if we have 'width:"100%"' for the table, replace "auto" width to "*"
+                if (fullWidth) tableWidths=tableWidths.map(function(w) { return w==='auto' ? '*' : w });
                 ret.table.widths = tableWidths;
               }
               if (tableHeights.length > 0) ret.table.heights = tableHeights;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "html-to-pdfmake",
-  "version": "2.4.6",
+  "version": "2.4.7",
   "description": "Convert HTML code to PDFMake",
   "main": "index.js",
   "scripts": {