Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit dependency to force protobuf update #407

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

abuijze
Copy link
Contributor

@abuijze abuijze commented Jan 14, 2025

The protobuf version was overridden for the build, but this was not forced to any upstream dependencies. That caused them to use protobuf 3.25, while the connector relies on 4.29.

The protobuf version was overridden for the build, but this was not forced to any upstream dependencies. That caused them to use protobuf 3.25, while the connector relies on 4.29.
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our offline discussions and viewing the changes, I approve this PR.

@smcvb smcvb merged commit 7b04b3c into connector-2024.2.x Jan 15, 2025
7 checks passed
@smcvb smcvb deleted the dependency-fix branch January 15, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants