Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure connections are properly closed in tests #403

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

abuijze
Copy link
Contributor

@abuijze abuijze commented Dec 30, 2024

Some connections were lingering, causing excessive logging of connection exceptions. This commit ensures that the connections are properly closed after the test.

Some connections were lingering, causing excessive logging of connection exceptions. This commit ensures that the connections are properly closed after the test.
Some connections were lingering, causing excessive logging of connection exceptions. This commit ensures that the connections are properly closed after the test.
@abuijze abuijze merged commit 58b4a5b into master Jan 6, 2025
7 checks passed
@smcvb smcvb deleted the improvement/close-connection-in-tests branch January 6, 2025 17:07
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems I am to late, but I am still approving this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants