Randomized connection order of servers #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randomizing the order in which servers are used for connections prevents a misbehaving (e.g. out of sync) first candidate to prevent the application from connecting via other instances in the cluster.
smcvb
reviewed
Oct 23, 2024
|
m1l4n54v1c
reviewed
Oct 23, 2024
| new ServerAddress("server3")), | ||
| connectAttempts); | ||
| // we don't care in which order the connects happened, as long as all hosts have been tried | ||
| assertEquals(new HashSet<>(asList(new ServerAddress("server1"), |
There was a problem hiding this comment.
Collections.unmodifiableSet(...) instead of new HashSet<>(asList(...))?
There was a problem hiding this comment.
Collections.unmodifiableSet(...) expects a Set, so that would change it to Collections.unmodifiableSet(new HashSet<>(asList(...).
smcvb
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomizing the order in which servers are used for connections prevents a misbehaving (e.g. out of sync) first candidate to prevent the application from connecting via other instances in the cluster.