Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 2 #16

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Patch 2 #16

wants to merge 7 commits into from

Conversation

Avitus27
Copy link
Owner

Logging more than a forester

TheJokersThief
TheJokersThief approved these changes Aug 31, 2018
View reviewed changes
Copy link

@TheJokersThief TheJokersThief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely recommend considering a bit of a restructure of the codebase so it's more approachable - either functional or object-oriented.

I've left a couple of suggests in the code but other than that, LGTM :) :shipit:

Main.py
str(page)))
logger.debug("Last seen torrent: %d" % last_seen_torrent)

try:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This try-except would be a good candidate for a function instead of inline

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it is pretty self-contained so it's perfect for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJokersThief TheJokersThief TheJokersThief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avitus27 @TheJokersThief