Skip to content

bump bson to 1.1.6 on 4.x #10489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2021
Merged

bump bson to 1.1.6 on 4.x #10489

merged 2 commits into from
Jul 28, 2021

Conversation

AbdelrahmanHafez
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez commented Jul 25, 2021

fixes #10484
The error is a false-positive that's happening with the build due to an issue with Travis.

@AbdelrahmanHafez AbdelrahmanHafez changed the title bump bson to 1.1.6 bump bson to 1.1.6 on 4.x Jul 25, 2021
@AbdelrahmanHafez AbdelrahmanHafez changed the base branch from 4.13 to 4.x July 25, 2021 07:20
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 4.13.22 milestone Jul 28, 2021
@vkarpov15 vkarpov15 merged commit d63d08c into Automattic:4.x Jul 28, 2021
@AbdelrahmanHafez
Copy link
Collaborator Author

Happy to help 👍

@AbdelrahmanHafez AbdelrahmanHafez deleted the patch-11 branch July 28, 2021 19:35
@vkarpov15
Copy link
Collaborator

I took a closer look at this and this change won't help. That's because Mongoose 4.x relies on MongoDB driver 2.x, which relies on mongodb-core@2.1.x, which relies on bson@~1.0.4. So this PR won't help unless we get mongodb-js/mongodb-core#464 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants