Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock file maintenance #39288

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Lock file maintenance #39288

merged 4 commits into from
Sep 9, 2024

Conversation

matticbot
Copy link
Contributor

@matticbot matticbot commented Sep 9, 2024 •
edited
Loading

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.

Configuration

📅 Schedule: Branch creation - "before 3:00 am on Monday on the 7th through 13th day of the month" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@matticbot matticbot added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Sep 9, 2024
@github-actions github-actions bot added [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Debug Helper Debug Tools plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh labels Sep 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the renovate/lock-file-maintenance branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack renovate/lock-file-maintenance

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin renovate/lock-file-maintenance

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@matticbot matticbot force-pushed the renovate/lock-file-maintenance branch from 4453e35 to fe6eb65 Compare September 9, 2024 13:39
zinigor
zinigor previously approved these changes Sep 9, 2024
View reviewed changes
@zinigor
Copy link
Member

zinigor commented Sep 9, 2024

The Jest test suite fails to run for some of the projects with the same error:

       Details:
  
      /home/runner/work/jetpack/jetpack/node_modules/.pnpm/parsel-js@1.1.2/node_modules/parsel-js/dist/parsel.js:392
      export { RECURSIVE_PSEUDO_CLASSES, RECURSIVE_PSEUDO_CLASSES_ARGS, TOKENS, TRIM_TOKENS, flatten, gobbleParens, parse, specificity, specificityToNumber, stringify, tokenize, tokenizeBy, walk };
      ^^^^^^
  
      SyntaxError: Unexpected token 'export'

@anomiex
Copy link
Contributor

anomiex commented Sep 9, 2024

Looks like parsel-js is a new dependency from Gutenberg's @wordpress/block-editor, and assumes that any browser environment is going to be esm. I filed LeaVerou/parsel#79 upstream about that, and I'll add it to the list in tools/js-tools/jest/jest-resolver.js to workaround.

Fixing that reveals more errors though.

@anomiex
Work around parsel-js assuming "browser" is esm
eb77ca6
@anomiex
Downgrade framer-motion to 11.4.0 to avoid a deprecation
2a7728a 
Gutenberg is planning on removing the dep entirely, so let's not go to too much trouble to work around it.
@zinigor zinigor merged commit 1e3851d into trunk Sep 9, 2024
73 checks passed
@zinigor zinigor deleted the renovate/lock-file-maintenance branch September 9, 2024 17:17
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 9, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
@matticbot @renovate-bot
@anomiex @gogdzl
Lock file maintenance (#39288)
4342e9d 
* Lock file maintenance

* Work around parsel-js assuming "browser" is esm

* Downgrade framer-motion to 11.4.0 to avoid a deprecation

Gutenberg is planning on removing the dep entirely, so let's not go to too much trouble to work around it.

* Remove pnpmfile hack for fixed issue

---------

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com>
lucatume added a commit to the-events-calendar/the-events-calendar that referenced this pull request Mar 24, 2025
@lucatume
test(classy_jest) use custom resolver
3cb5e05 
Some modules, currently the `parsel-js` one, will assume a browser
working environment (LeaVerou/parsel#79) and
that will make them break the Jest tests. Following the solution in the
PR Automattic/jetpack#39288; this restores the
Jest tests to full function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor left review comments

Assignees
No one assigned
Labels
[Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Debug Helper Debug Tools plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matticbot @zinigor @anomiex @renovate-bot