Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum Limit of 1.4 MB #126

Open
just-kirb opened this issue Sep 2, 2024 · 7 comments
Open

Maximum Limit of 1.4 MB #126

just-kirb opened this issue Sep 2, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@just-kirb
Copy link

Describe the bug
A game cannot store over 1.4MB of data in a link as it starts deleting the ending lines of code.

Reproduction Steps

  1. Make a game with lots of rules to check and exceed 1.4MB of data.
  2. Share the game with the link.
  3. Open it.

What did you expect would happen?
The data being intact after sharing the link to others.

OS & Browser version, desktop/mobile
Edition: Windows 10 Home Single Language
OS Version: 22H2
Firefox Version 129.0.2 (64-bit)

Screenshots, example projects, other relevant issues, etc.
image
information before sharing the link
image
information removed when sharing the link

@just-kirb just-kirb added the bug Something isn't working label Sep 2, 2024
@david-pfx
Copy link

Data? Do you means lines of script code? That would be maybe 50 KLOC. Do games that big actually work?

@just-kirb
Copy link
Author

I mean the games up until that point work fine when programming, however the issue probably comes from GitHub's limit on storing data in links (i verified saving the game doesn't cause an override, but sharing it though a link does), here is a video demonstrating the problem more clearly:

Bug.Showcase.mp4

@just-kirb
Copy link
Author

UPDATE: i feel like the puzzlescript machine for github gists only scraped a truncated portion of the script, and not the actual full version, causing a cutoff, but the full file is still intact

@david-pfx
Copy link

david-pfx commented Sep 4, 2024 via email

@just-kirb
Copy link
Author

just-kirb commented Sep 4, 2024 via email

@david-pfx
Copy link

Yes, it's real. It seems to affect every fork. It truncates in line 22977.

Is it a Github problem/limit? In any case, I don't this is fixable.

@just-kirb
Copy link
Author

just-kirb commented Sep 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants