-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximum Limit of 1.4 MB #126
Comments
Data? Do you means lines of script code? That would be maybe 50 KLOC. Do games that big actually work? |
I mean the games up until that point work fine when programming, however the issue probably comes from GitHub's limit on storing data in links (i verified saving the game doesn't cause an override, but sharing it though a link does), here is a video demonstrating the problem more clearly: Bug.Showcase.mp4 |
UPDATE: i feel like the puzzlescript machine for github gists only scraped a truncated portion of the script, and not the actual full version, causing a cutoff, but the full file is still intact |
I’m happy to look at it, but I do need a repro. The Gist maybe.
Regards
David M Bennett FACS
…_____
Polyomino Games – Programming Languages and Players for Games and Puzzles -- http://www.polyomino.com <http://www.polyomino.com/>
From: just-kirb ***@***.***>
Sent: Wednesday, 4 September 2024 10:01 PM
To: Auroriax/PuzzleScriptPlus ***@***.***>
Cc: david-pfx ***@***.***>; Comment ***@***.***>
Subject: Re: [Auroriax/PuzzleScriptPlus] Maximum Limit of 1.4 MB (Issue #126)
UPDATE: i feel like the puzzlescript machine for github gists only scraped a truncated portion of the script, and not the actual full version, causing a cutoff, but the full file is still intact
—
Reply to this email directly, view it on GitHub <#126 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBMEXJIPMS6MT4NY2VE6MTZU3Y7TAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYG43TQMBUHA> .
You are receiving this because you commented.Message ID: ***@***.***>
|
… On Wed, Sep 4, 2024 at 8:20 PM david-pfx ***@***.***> wrote:
I’m happy to look at it, but I do need a repro. The Gist maybe.
Regards
David M Bennett FACS
_____
Polyomino Games – Programming Languages and Players for Games and Puzzles
-- http://www.polyomino.com <http://www.polyomino.com/>
From: just-kirb ***@***.***>
Sent: Wednesday, 4 September 2024 10:01 PM
To: Auroriax/PuzzleScriptPlus ***@***.***>
Cc: david-pfx ***@***.***>; Comment ***@***.***>
Subject: Re: [Auroriax/PuzzleScriptPlus] Maximum Limit of 1.4 MB (Issue
#126)
UPDATE: i feel like the puzzlescript machine for github gists only scraped
a truncated portion of the script, and not the actual full version, causing
a cutoff, but the full file is still intact
—
Reply to this email directly, view it on GitHub <
#126 (comment)>
, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ADBMEXJIPMS6MT4NY2VE6MTZU3Y7TAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYG43TQMBUHA>
.
You are receiving this because you commented.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKAS3CQNV3GAJAXKLOV7KRDZU33HBAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYHAZTAMBXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yes, it's real. It seems to affect every fork. It truncates in line 22977. Is it a Github problem/limit? In any case, I don't this is fixable. |
wait the github program that runs puzzlescript plus doesn't have a way to
scrape gists fully if it's truncated?
…On Fri, Sep 6, 2024 at 9:37 PM david-pfx ***@***.***> wrote:
Yes, it's real. It seems to affect every fork. It truncates in line 22977.
Is it a Github problem/limit? In any case, I don't this is fixable.
—
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKAS3CVPF35BGEZ2KFX27H3ZVGV2TAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGA3TSMJQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Describe the bug
A game cannot store over 1.4MB of data in a link as it starts deleting the ending lines of code.
Reproduction Steps
What did you expect would happen?
The data being intact after sharing the link to others.
OS & Browser version, desktop/mobile
Edition: Windows 10 Home Single Language
OS Version: 22H2
Firefox Version 129.0.2 (64-bit)
Screenshots, example projects, other relevant issues, etc.
![image](https://private-user-images.githubusercontent.com/176237962/363574608-94fb4d9c-0cf0-4f3b-9272-3407fc471171.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzY3ODQsIm5iZiI6MTczOTAzNjQ4NCwicGF0aCI6Ii8xNzYyMzc5NjIvMzYzNTc0NjA4LTk0ZmI0ZDljLTBjZjAtNGYzYi05MjcyLTM0MDdmYzQ3MTE3MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQxNzQxMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZDY3OWMxMTc5ZmFjZjNiMDRmODAwZDZlZjZlYTNmNGQ2M2UyMDc5MzU3ODAwMzU2MjA4OWZhOTgzYTFjODdlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Apbo6-qQfSiZ3g_ZN9OPBxYciWNo5S5H_fF8s2pTP-4)
![image](https://private-user-images.githubusercontent.com/176237962/363574407-7161475d-212b-4a89-a2a9-b2838c9fc238.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzY3ODQsIm5iZiI6MTczOTAzNjQ4NCwicGF0aCI6Ii8xNzYyMzc5NjIvMzYzNTc0NDA3LTcxNjE0NzVkLTIxMmItNGE4OS1hMmE5LWIyODM4YzlmYzIzOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQxNzQxMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMmU4OGU2Y2YwYzY4MzM1YzU2ZWVjMTg1ZWQyM2E2ZDIzNDkwNGIzMGY0NjdmMzg3ZDZmMmI4YWI2YjczNTU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.qCQ44JWRexuHi0tQVtTF_F_0AnFjRsuKr__ziB-XSls)
information before sharing the link
information removed when sharing the link
The text was updated successfully, but these errors were encountered: