Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting tools #269

Closed
rs028 opened this issue Apr 25, 2018 · 3 comments
Closed

Plotting tools #269

rs028 opened this issue Apr 25, 2018 · 3 comments

Comments

@rs028
Copy link
Collaborator

rs028 commented Apr 25, 2018

Python script:

  • import too many libraries?
  • generally slow
  • inefficient way to read file header and data (open file twice)
  • spacing between panels

gnuplot script:

  • does not read variable names from file header
  • unequal dimension of panels
  • spacing between panels

Matlab/Octave script:

  • inefficient way to read file header and data (open file twice)
  • does not save to pdf
@rs028 rs028 mentioned this issue Apr 25, 2018
@rs028 rs028 changed the title Plotting tools issues Plotting tools May 18, 2018
@rs028
Copy link
Collaborator Author

rs028 commented May 17, 2019

Python version fixed by PR #394, but still slow. The version with pandas is only marginally quicker than the version with numpy. (keep both?)

@spco
Copy link
Collaborator

spco commented May 21, 2019

For reference, it's not the data processing that's really expensive - it's the many calls to savefig() and tight_layout() that do the damage, as seen in this flame graph (this is for the case I'm investigating in #384). save_fig() is taking 0.7s per PDF page (of which there are 12 = 8.4s), while tight_layout() is taking 0.192s per graph (there are 62 of these = 11.9s) :
Screenshot 2019-05-21 at 14 00 15

@rs028 rs028 moved this to Minor Improvements in Roadmap Sep 22, 2022
@rs028 rs028 added this to Roadmap Sep 22, 2022
@rs028 rs028 added this to the version 1.4 milestone Oct 6, 2022
@rs028
Copy link
Collaborator Author

rs028 commented Mar 28, 2023

PR #490 solves this issue -- except for the Python scripts being slow (not sure it can be easily solved, but it's largely just an annoying thing).

@rs028 rs028 closed this as completed Mar 28, 2023
@rs028 rs028 removed this from Roadmap Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants