Skip to content
This repository has been archived by the owner on May 8, 2021. It is now read-only.

🚨 [security] Update jquery: 3.4.1 → 3.5.0 (minor) #58

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 30, 2020


🚨 Your version of jquery has known security vulnerabilities 🚨

Advisory: CVE-2020-11023
Disclosed: April 29, 2020
URL: https://github.com/jquery/jquery/security/advisories/GHSA-jpcq-cgw6-v4j6

Potential XSS vulnerability in jQuery

Impact

Passing HTML containing <option> elements from untrusted sources - even after sanitizing it - to one of jQuery's DOM manipulation methods (i.e. .html(), .append(), and others) may execute untrusted code.

Patches

This problem is patched in jQuery 3.5.0.

Workarounds

To workaround this issue without upgrading, use DOMPurify with its SAFE_FOR_JQUERY option to sanitize the HTML string before passing it to a jQuery method.

References

https://jquery.com/upgrade-guide/3.5/

For more information

If you have any questions or comments about this advisory:


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ jquery (3.4.1 → 3.5.0) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Apr 30, 2020
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #58 into electron-rewrite will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           electron-rewrite      #58   +/-   ##
=================================================
  Coverage             92.89%   92.89%           
=================================================
  Files                    14       14           
  Lines                   366      366           
  Branches                 66       67    +1     
=================================================
  Hits                    340      340           
  Misses                   26       26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec13aa6...4cb2c00. Read the comment docs.

@depfu
Copy link
Contributor Author

depfu bot commented May 6, 2020

Closed in favor of #60.

1 similar comment
@depfu
Copy link
Contributor Author

depfu bot commented May 6, 2020

Closed in favor of #60.

@depfu depfu bot closed this May 6, 2020
@depfu depfu bot deleted the depfu/update/npm/jquery-3.5.0 branch May 6, 2020 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants