Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate OptimalSwapRouter in SwapRouter to remove dependency #35

Open
shuhuiluo opened this issue Nov 24, 2023 · 1 comment
Open

Incorporate OptimalSwapRouter in SwapRouter to remove dependency #35

shuhuiluo opened this issue Nov 24, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shuhuiluo
Copy link
Contributor

shuhuiluo commented Nov 24, 2023 •
edited
Loading

Incorporate the logic in OptimalSwapRouter to SwapRouter. Make a optimal swap in the same pool after a router swap. Refactor tests accordingly.
@shuhuiluo shuhuiluo added enhancement New feature or request good first issue Good for newcomers labels Nov 24, 2023
@gnarlycow
Copy link
Contributor

@shuhuiluo Could you please add a description with more details on what needs to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnarlycow @shuhuiluo