Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emscripten deviceLostCallbackInfo #46

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

MichealReed
Copy link
Contributor

Found out this is available in the native headers but not the emscripten headers. This PR checks for and excludes the callback if emscripten.

https://github.com/eliemichel/WebGPU-Cpp/blob/main/emscripten/webgpu.hpp

vs

https://github.com/eliemichel/WebGPU-Cpp/blob/main/dawn/webgpu.h

@austinvhuang
Copy link
Contributor

Thanks, wil go ahead and merge.

As a note for ourselves we'll eventually want to migrate to the new DeviceLostCallBack type here `https://github.com/emscripten-core/emscripten/blob/f92abe4f715d086d4c7cd5a16620bbf5ec838cb6/system/include/webgpu/webgpu.h#L1345 though may hold off on doing that right away because it will break users on versions of emscripten besides HEAD.

More generally we'll want to think about how we pin webgpu implementation versions of dependencies for emscripten builds, native builds and the prebuilt dawn binary, and from-scratch dawn builds.

@austinvhuang austinvhuang merged commit 73c07af into AnswerDotAI:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants