-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Enhanced Roll table usage. #62
Comments
Thx for clarification. My thoughts about exaclty this solution: Technically this has to wait for another feature request that already wanted the rollTable result move towards the end of the crafting process currently it is rolled before your first skill check. If i got that i will look into this request again and will decide if it is mainstream enough to bring it into the ui or which i currently prefer implement a second macro phase that gets exectued when producing results and return the real results of the crafting process. |
Those are all fair points and I understand completely. Perhaps then I could change the request to just being able to store a roll result in some variables that gets overridden with each roll attempt. That way when you do the advanced macros one could use macros to solve this specific use case by simply calling that variable. Maybe it’s stored as @player.roll or something and is updated with every crafting check so it only ever stores a single value. This way, it could solve specific use cases without cluttering the ui or complicating the wiki. Would only need to list the variable name in the wiki and state that it stores the most recent crafting check roll value. |
With the current implementation of the crafting system, it is possible to on a successful craft, roll on a roll table, providing the appropriate reward based off the tables roll. I propose an enhanced version of this that allows using the roll performed for the crafting check as the roll table formula.
To give an example, the player wants to craft a potion of healing. They first acquire the ingredients as required in the recipe below.
![image](https://private-user-images.githubusercontent.com/63491456/252120987-1ef01b8a-70c8-4288-97f0-e4c8162ba7ef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTU5MTQsIm5iZiI6MTczOTE5NTYxNCwicGF0aCI6Ii82MzQ5MTQ1Ni8yNTIxMjA5ODctMWVmMDFiOGEtNzBjOC00Mjg4LTk3ZjAtZTRjODE2MmJhN2VmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEzNTMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjZmViMmRkNmE1ZTM5NDI3YzAzZmU2OTgxOGVhZmU5NDRlYTU1MDNjMWFjMjRkMjRiMDAxMzI1ODU1ZDgzM2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.MXz1ulETxgtvRxUJtxTKQGMTQY5SZxgY05y-6yolyxA)
Then they perform the craft and get a result of 15.
![image](https://private-user-images.githubusercontent.com/63491456/252120996-c1f6d20f-ccc7-4db0-a137-281234bf15da.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTU5MTQsIm5iZiI6MTczOTE5NTYxNCwicGF0aCI6Ii82MzQ5MTQ1Ni8yNTIxMjA5OTYtYzFmNmQyMGYtY2NjNy00ZGIwLWExMzctMjgxMjM0YmYxNWRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEzNTMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBmZWFlM2Y4MDhmZTZkYTk3Y2NjMWJlZmNlNjFlMTU4MGJiYWM1Mzg3YTcxZTgwYjcwNWYxYjZjYjc1YTk1YWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.0dA-g3j1JWQvzY-6BcOMlAbLubmgANWYQdklNoqKV6E)
As per the crafting ruled of this arbitrarily chosen system, rolling a 15 when crafting a potion of healing results in a craft of a higher quality!
![image](https://private-user-images.githubusercontent.com/63491456/252121066-b32c7b28-3c11-4896-8ca8-2f699e393387.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTU5MTQsIm5iZiI6MTczOTE5NTYxNCwicGF0aCI6Ii82MzQ5MTQ1Ni8yNTIxMjEwNjYtYjMyYzdiMjgtM2MxMS00ODk2LThjYTgtMmY2OTllMzkzMzg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEzNTMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY3YWI2ZDYyMWYxOWVlNGM3OWI5NWFiMTg5M2I3NzE4ZWZmMTNiY2Q3MTkyNTlkMmIzNzU2OGM5MmZlMjNkZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mD4DIerh0RYRPZGEqKqFfftQtb_sWjHHM99Tw4_y7ps)
As the current system is implemented, the crafting result will make a NEW roll on the roll table, potentially yielding a different result than their crafting check.
If we could have a button located here (poorly diagrammed in the image below) whereby when checked, whatever the result of the crafting check (seen in the first image) is placed in the roll table formula (highlighted in the second image) as a static number. That way whatever number rolled for their crafting check is used as the number for their roll table and they get the appropriate reward (in this case a potion of great healing).
![image](https://private-user-images.githubusercontent.com/63491456/252121142-833ec19e-2ce4-46f6-b7c3-72c15d320ec8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTU5MTQsIm5iZiI6MTczOTE5NTYxNCwicGF0aCI6Ii82MzQ5MTQ1Ni8yNTIxMjExNDItODMzZWMxOWUtMmNlNC00NmY2LWI3YzMtNzJjMTVkMzIwZWM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEzNTMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEyZWVhNzE3NDA5MzAxYTU5NWZmMDNmY2FhYzU3M2NkMWM4Mjk3N2RkMGMzMjVhN2QwMWMyMDZjN2MyNWMxODkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.R6ZdSkHJZASeF-WW49tc3PRFluv9ycug_V7pqYIDWxc)
In this case, when checking that button, the roll table will have this field updated with the result of their crafting roll as a static number BEFORE the roll on the table is taken, thus guaranteeing the appropriate result.
![image](https://private-user-images.githubusercontent.com/63491456/252121176-8fa00389-15e2-4846-85a9-d37da33f51cb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTU5MTQsIm5iZiI6MTczOTE5NTYxNCwicGF0aCI6Ii82MzQ5MTQ1Ni8yNTIxMjExNzYtOGZhMDAzODktMTVlMi00ODQ2LTg1YTktZDM3ZGEzM2Y1MWNiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEzNTMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNjNTc5YjA3ODMxM2ViNjNlMDJhMzJlYjhiMzJjYjZkN2FjNmFiMWYxZGQ5N2ZhNTYwOTI4OTg1ZjlmNTNjODMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.fVg8pKUVdoFrUp-mHzVm1lUC1Te64lgy8PRXhpqPNPE)
The text was updated successfully, but these errors were encountered: