Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical glass slab texture #5

Closed
dadoirie opened this issue Aug 14, 2023 · 6 comments
Closed

vertical glass slab texture #5

dadoirie opened this issue Aug 14, 2023 · 6 comments
Labels
Feature Request New feature request

Comments

@dadoirie
Copy link
Contributor

that's what I meant earlier in a another issue - btw those are from Mo Glass

image
image
image
image
image
image

@Andrew6rant
Copy link
Owner

This isn't an AutoSlabs issue, Mo' Glass handles their models in a weird way. You can fix it with a resource pack.

I might look into adding built-in support though.

@dadoirie
Copy link
Contributor Author

no idea how the resourcepack should be looking - I'm just starting with a GUI resource pack - not touching blocks (for now ... and if then just adding some tweaks like shiny animation with mcmeta when a amethyst cluster is ready ... still learning)

@Andrew6rant Andrew6rant added the Feature Request New feature request label Aug 14, 2023
@Andrew6rant
Copy link
Owner

AutoSlabs Mo' Glass texture compat

Here is a commit that adds texture and model support to Mo Glass' glass slab: b33cd4b. You can see how I set up the model JSONs. I'm not going to add support for the rest of Mo Glass' blocks (not now, at least), so if you want them in the mod, feel free to make a PR.

@dadoirie
Copy link
Contributor Author

thanks - will take a look

@Andrew6rant
Copy link
Owner

Related issue - #12

@dadoirie
Copy link
Contributor Author

dadoirie commented Aug 29, 2023

sorry for that late PR #17 - tested and works ... yeah I did notice #12 and notice also sometimes randomly switching place from left to right or vice versa(and even from vertical to horizontal & vice versa, but this one is very rare) when placing a vertical slab - which ain't either a huge deal as it doesn't happen that often (but that's another issue not related with this one as it doesn't affect only glass slabs)

EDIT: feel free closing this issue once #17 is accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants