Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTL app + reverse proxy #3

Open
floviolleau opened this issue Feb 6, 2023 · 3 comments
Open

INTL app + reverse proxy #3

floviolleau opened this issue Feb 6, 2023 · 3 comments

Comments

@floviolleau
Copy link

Hi,

Thanks for all the tremendous work you achieved. I'm the owner as well of an edilkamin 😀

I managed to make your project working on my own RPi and my edilkamin pellet stove.

I'm preparing a PR for you to handle:

  • translations fr / en of current hard-coded strings
  • routes prefix with the locale
  • extract useful info like error alarms, scheduling, fan speed in sections
  • better debug output with integration of https://www.npmjs.com/package/react-json-view

Could be nice if we can have a realtime values or refresh every X min (but I will think about it later)

Thanks

@AndreMiras
Copy link
Owner

Hi @floviolleau,
Pretty cool thanks a lot!
How about breaking down the change into multiple PR?

@floviolleau
Copy link
Author

floviolleau commented Feb 6, 2023

For the first 1, 2,4 and reverse proxy => one PR (I have already something working)
For 3, I have not started it so ti will be another one

@floviolleau
Copy link
Author

See PR #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants